Tweak abstractmethods (#8427)

Author: crusaderky

distributed/actor.py

@@ -246,11 +246,11 @@ class BaseActorFuture(abc.ABC, Awaitable[_T]):
 
     @abc.abstractmethod
     def result(self, timeout: str | timedelta | float | None = None) -> _T:
-        ...  # pragma: nocover
+        ...
 
     @abc.abstractmethod
     def done(self) -> bool:
-        ...  # pragma: nocover
+        ...
 
     def __repr__(self) -> Literal["<ActorFuture>"]:
         return "<ActorFuture>"

distributed/scheduler.py

@@ -2823,7 +2823,7 @@ def transition_memory_forgotten(self, key: Key, stimulus_id: str) -> RecsMsgs:
                 # It's ok to forget a task that nobody needs
                 pass
             else:
-                raise AssertionError("Unreachable", ts)  # pragma: nocover
+                raise AssertionError("Unreachable", str(ts))  # pragma: nocover
 
         if ts.actor:
             for ws in ts.who_has or ():

distributed/shuffle/_buffer.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import abc
 import asyncio
 import contextlib
 import logging
@@ -126,11 +127,12 @@ async def process(self, id: str, shards: list[ShardType], size: int) -> None:
             await self.memory_limiter.decrease(size)
             self.bytes_memory -= size
 
+    @abc.abstractmethod
     async def _process(self, id: str, shards: list[ShardType]) -> None:
-        raise NotImplementedError()
+        ...
 
     def read(self, id: str) -> ShardType:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover
 
     @property
     def empty(self) -> bool:

distributed/shuffle/_core.py

@@ -434,10 +434,10 @@ class ShuffleSpec(abc.ABC, Generic[_T_partition_id]):
     id: ShuffleId
     disk: bool
 
-    @abc.abstractproperty
+    @property
+    @abc.abstractmethod
     def output_partitions(self) -> Generator[_T_partition_id, None, None]:
         """Output partitions"""
-        raise NotImplementedError
 
     @abc.abstractmethod
     def pick_worker(self, partition: _T_partition_id, workers: Sequence[str]) -> str:

pyproject.toml

@@ -243,6 +243,8 @@ exclude_lines = [
     "TYPE_CHECKING",
     "except ImportError",
     "@overload",
+    "@abstractmethod",
+    "@abc.abstractmethod"
 ]
 
 [tool.coverage.html]