Skip to content

WIP: Support specifying multiple dashboard addresses. #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Arsenal591
Copy link

@Arsenal591 Arsenal591 commented Oct 25, 2022

When launching dask-worker with nworkers>1, support specifying multiple dashboard addresses for each workers by using commas to separate them. For example, --dashboard-address=3000,3001,3002 will use ports 3000, 3001, 3002.

I didn't use the same logic as in --worker-port since --worker-port use : to specify a port range, but : does not work in ip address. So I instead use commas to separate multiple ip addresses.

Closes #7147

  • Tests added / passed
  • Passes pre-commit run --all-files

@Arsenal591 Arsenal591 changed the title Support specifying multiple dashboard addresses. Draft: Support specifying multiple dashboard addresses. Oct 25, 2022
@Arsenal591 Arsenal591 marked this pull request as draft October 25, 2022 16:17
@Arsenal591 Arsenal591 changed the title Draft: Support specifying multiple dashboard addresses. WIP: Support specifying multiple dashboard addresses. Oct 25, 2022
@Arsenal591 Arsenal591 marked this pull request as ready for review October 25, 2022 16:51
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±  0         15 suites  ±0   6h 27m 9s ⏱️ + 12m 15s
  3 161 tests +  5    3 070 ✔️ +  7    85 💤 ±0    6  - 2 
23 384 runs  +35  22 450 ✔️ +38  913 💤  - 1  21  - 2 

For more details on these failures, see this check.

Results for commit acc4ddc. ± Comparison against base commit 0983731.

@Arsenal591 Arsenal591 requested a review from fjetter as a code owner January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support specifying dashboard port ranges when launching workers with multi-processing.
1 participant