Poll in test_rmm_metrics test#9004
Merged
jacobtomlinson merged 1 commit intodask:mainfrom Feb 5, 2025
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 32m 52s ⏱️ - 1m 45s For more details on these failures and errors, see this check. Results for commit 02c1e43. ± Comparison against base commit b86b714. |
jacobtomlinson
approved these changes
Feb 5, 2025
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
This looks more robust to me, thanks @TomAugspurger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref rapidsai/dask-upstream-testing#4
The 1 second deadline on this test was a little tight (it usually took between 0.75-1s for me locally). I changed the 1s sleep to use a
distributed.utils.Deadlinewith polling every 0.25 seconds for up to 5 seconds.cc @jacobtomlinson