Remove traceback from sizeof failure warning#9006
Conversation
jacobtomlinson
changed the title
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 47m 22s ⏱️ + 13m 15s For more details on these failures and errors, see this check. Results for commit 8b5874e. ± Comparison against base commit 55bb639. |
fjetter
left a comment
fjetter
left a comment
There was a problem hiding this comment.
Thanks! I assume you ran into this yourself? sizeof warnings are not critical but if the estimation is wrong this can cause uncomfortable scheduling artifacts so I recommend looking into it. I agree that we don't need to spam the logs because of this.
|
No I didn't run into this. I was just triaging issues and this one seemed like a quick fix. |
2 participants
Closes #8566
Logging the traceback from a
sizeoffailure seems like it doesn't add much value to users. It might be helpful when debugging why it's happening.This PR removes the traceback from the warning but adds a debug log which includes the traceback. This allows folks to see it when they want to by setting the appropriate log level.
pre-commit run --all-files