-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
When the leader's gRPC address is malformed, Endpoint::parse() silently returns None instead of surfacing the error.
Location
crates/service/src/meta_node/meta_node.rs:1630
Endpoint::parse(addr).ok()Problem
If a node's grpc_api_advertise_address contains an invalid address, the error is silently swallowed. Users see "no leader available" when the actual problem is a configuration error.
This could waste hours of debugging because:
- The actual error is hidden
- "No leader" suggests a cluster health issue, not a config issue
- No logging indicates what went wrong
Impact
- Configuration errors appear as cluster failures
- Difficult to diagnose misconfigured nodes
- Misleading error messages to operators
Suggested Fix
Return a proper error:
fn get_leader_endpoint(&self, addr: &str) -> Result<Endpoint, MetaError> {
Endpoint::parse(addr).map_err(|e| {
MetaError::InvalidConfig(format!(
"Invalid leader endpoint '{}': {}", addr, e
))
})
}Priority
P3 - Debuggability improvement
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request