feat(storage): add endpoint egress policy#19980
Draft
youngsofun wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 043ca26b91
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
043ca26 to
589f70f
Compare
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
589f70f to
9448e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Add a configurable storage endpoint egress policy for external storage
endpoint_urlvalues. This gives deployments a server-side control to reject high-risk targets such as loopback, private/link-local ranges, metadata endpoints, and configured databend-meta sockets while keeping the default behavior permissive for self-hosted compatibility.The policy is enforced in two places: early endpoint parsing for storage locations, and the storage HTTP client before requests are sent. The default
permissivemode preserves existing S3-compatible/private storage setups, whilestrictmode enables stronger protection for Cloud or hardened deployments.This also treats wildcard databend-meta binds such as
0.0.0.0:9191as protected sockets for local/private targets, and pins hostname requests to the DNS addresses that passed policy validation.Tests
Executed:
cargo fmt --checkcargo test -p databend-common-storage endpoint_policy --libcargo clippy -p databend-common-storage --lib -- -D warningscargo check -p databend-common-config -p databend-common-sqlAlso updated
configs_table_basic.txtgolden output for the new storage endpoint policy config rows.Type of change
This change is