refactor(storage): remove native storage format#19982
Open
zhang2014 wants to merge 3 commits into
Open
Conversation
Remove the legacy native columnar format and its compression codecs, readers, and writers. Fuse tables now use parquet exclusively for block storage. - Delete the src/common/native crate and its workspace entry - Drop native block readers, writers, and deserializers in fuse storage - Remove native compression option from table create/alter validation - Drop the fuse_encoding table function's native-specific output - Remove explain_native sqllogic suites and native-only test cases - Update CI sqllogic scripts and adjust affected tests
github-actions
Bot
added
the
pr-refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a68733bbf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
Follow-up to removing the native storage format. Drop the remaining native-specific CI scripts, deploy config, workflow steps, and benchmark table definitions that referenced the removed format. - Delete native sqllogic CI scripts and standalone deploy config/script - Remove native sqllogic steps from GitHub workflow actions - Drop native storage_format usage from benchmark SQL and scripts - Stop generating native engine options in sqlsmith DDL
Remove the remaining native storage format test cases that no longer apply after the format was removed. - Drop native impl calls from aggregating index scan tests - Remove native variant from agg index query rewrite test - Update expected read size in cross join aggregation fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Remove the legacy native columnar format and its compression codecs, readers, and writers. Fuse tables now use parquet exclusively for block storage.
Tests
Type of change
This change is