Commit ff7ba4e
authored
Fix pipeline allow_duplicate_names never converges (#6076)
## Changes
Declare pipeline `allow_duplicate_names` as `input_only` in
`ignore_remote_changes`, next to the existing `run_as` entry. Adds a
`no_drift` invariant config covering it.
## Why
The field is only carried by `CreatePipeline`/`EditPipeline` and is
never returned by GET, so remote always reads back `false`. With
`allow_duplicate_names: true`, every plan after a deploy reported a
perpetual update (`old: true, new: true` — config unchanged, phantom
remote drift). It's in `RemoteType` via the embedded `CreatePipeline`,
so the automatic `missing_in_remote` suppression doesn't apply.
`dry_run` is request-only in the same way, but `EditPipeline` has no
`DryRun` field, so it needs its own fix and is out of scope here.
## Tests
New `pipeline_allow_duplicate_names.yml.tmpl` invariant config: fails on
`main`, passes with the fix. Also confirmed on dogfood — perpetual `1 to
change` across three deploys before the fix, control pipeline without
the field clean.1 parent f496c89 commit ff7ba4e
9 files changed
Lines changed: 22 additions & 0 deletions
File tree
- .nextchanges/bundles
- acceptance/bundle/invariant
- configs
- continue_293
- delete_idempotent
- destroy_idempotent
- migrate
- no_drift
- bundle/direct/dresources
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
183 | 187 | | |
184 | 188 | | |
185 | 189 | | |
| |||
0 commit comments