Simplifying backends + borrowing translation from sparklyr + fixing behaviour

Author: Zac Davies

NAMESPACE

@@ -4,6 +4,7 @@ S3method(dbplyr_edition,DatabricksConnection)
 S3method(sql_query_fields,DatabricksConnection)
 S3method(sql_query_save,DatabricksConnection)
 S3method(sql_table_analyze,DatabricksConnection)
+S3method(sql_translation,DatabricksConnection)
 export(DatabricksSQL)
 export(access_control_req_group)
 export(access_control_req_user)
@@ -276,27 +277,33 @@ exportMethods(show)
 import(DBI)
 import(cli)
 import(httr2)
-importFrom(DBI,SQL)
 importFrom(R6,R6Class)
 importFrom(cli,cli_abort)
 importFrom(dbplyr,base_agg)
 importFrom(dbplyr,base_scalar)
 importFrom(dbplyr,base_win)
+importFrom(dbplyr,build_sql)
 importFrom(dbplyr,dbplyr_edition)
+importFrom(dbplyr,simulate_spark_sql)
 importFrom(dbplyr,sql)
 importFrom(dbplyr,sql_prefix)
 importFrom(dbplyr,sql_query_fields)
 importFrom(dbplyr,sql_query_save)
 importFrom(dbplyr,sql_quote)
 importFrom(dbplyr,sql_table_analyze)
+importFrom(dbplyr,sql_translation)
 importFrom(dbplyr,sql_translator)
 importFrom(dbplyr,sql_variant)
 importFrom(dbplyr,translate_sql)
+importFrom(dbplyr,win_current_group)
+importFrom(dbplyr,win_current_order)
+importFrom(dbplyr,win_over)
 importFrom(glue,glue)
 importFrom(glue,glue_sql)
 importFrom(methods,new)
 importFrom(methods,setClass)
 importFrom(methods,setMethod)
+importFrom(rlang,"%||%")
 importFrom(rlang,.data)
 importFrom(stats,setNames)
 importFrom(utils,object.size)

R/databricks-dbi.R

@@ -621,3 +621,52 @@ setMethod("dbDataType", "DatabricksConnection", function(dbObj, obj, ...) {
     }
   )
 })
+
+# Identifier Quoting Methods ----------------------------------------------------
+
+#' Quote identifiers for Databricks SQL
+#' @param conn A DatabricksConnection object
+#' @param x Character vector of identifiers to quote
+#' @param ... Additional arguments (ignored)
+#' @return SQL object with quoted identifiers
+#' @export
+setMethod(
+  "dbQuoteIdentifier",
+  signature("DatabricksConnection", "character"),
+  function(conn, x, ...) {
+    # Simple identifiers - wrap in backticks
+    quoted <- paste0("`", x, "`")
+    DBI::SQL(quoted)
+  }
+)
+
+#' Quote SQL objects (passthrough)
+#' @param conn A DatabricksConnection object
+#' @param x SQL object (already quoted)
+#' @param ... Additional arguments (ignored)
+#' @return The SQL object unchanged
+#' @export
+setMethod(
+  "dbQuoteIdentifier",
+  signature("DatabricksConnection", "SQL"),
+  function(conn, x, ...) {
+    # SQL objects are already quoted
+    x
+  }
+)
+
+#' Quote complex identifiers (schema.table)
+#' @param conn A DatabricksConnection object
+#' @param x Id object with catalog/schema/table components
+#' @param ... Additional arguments (ignored)
+#' @return SQL object with quoted identifier components
+#' @export
+setMethod(
+  "dbQuoteIdentifier",
+  signature("DatabricksConnection", "Id"),
+  function(conn, x, ...) {
+    # Handle schema.table identifiers
+    names <- purrr::map_chr(x@name, ~ paste0("`", .x, "`"))
+    DBI::SQL(paste(names, collapse = "."))
+  }
+)