fix(db_sql_warehouse): forward tags to the API (#240)

Author: m-muecke

NEWS.md

@@ -3,6 +3,7 @@
 -   Fixed `git_source()` erroring when `type` was left at its default
 -   Fixed Unity Catalog volume file requests so `db_volume_*` paths containing spaces are encoded correctly (#231)
 -   `db_cluster_events()` now forwards the `event_types` argument to the API, which was previously ignored
+-   `db_sql_warehouse_create()` and `db_sql_warehouse_edit()` now forward the `tags` argument to the API, which was previously ignored
 -   `db_uc_volumes_list()` now forwards the `max_results`, `include_browse`, and `page_token` arguments to the API, which were previously ignored
 -   `db_vs_indexes_query()` now sends the `score_threshold` argument to the API, which was previously ignored
 -   Added `show_progress` to `dbConnect()` for the DBI backend; `dbGetQuery()`, `dbFetch()`, `dbWriteTable()`, and dbplyr `collect()` now use the connection default while preserving per-call `show_progress` overrides (#223)

R/warehouses.R

@@ -79,6 +79,7 @@ db_sql_warehouse_create <- function(
     min_num_clusters = min_num_clusters,
     max_num_clusters = max_num_clusters,
     auto_stop_mins = auto_stop_mins,
+    tags = tags,
     spot_instance_policy = spot_instance_policy,
     enable_photon = enable_photon,
     warehouse_type = warehouse_type,
@@ -195,6 +196,7 @@ db_sql_warehouse_edit <- function(
     min_num_clusters = min_num_clusters,
     max_num_clusters = max_num_clusters,
     auto_stop_mins = auto_stop_mins,
+    tags = tags,
     spot_instance_policy = spot_instance_policy,
     enable_photon = enable_photon,
     warehouse_type = warehouse_type,

tests/testthat/test-warehouses.R

@@ -1,5 +1,4 @@
 test_that("Warehouse API - don't perform", {
-
   withr::local_envvar(c(
     "DATABRICKS_HOST" = "http://mock_host",
     "DATABRICKS_TOKEN" = "mock_token"
@@ -11,13 +10,17 @@ test_that("Warehouse API - don't perform", {
   resp_global_get <- db_sql_global_warehouse_get(perform_request = FALSE)
   expect_s3_class(resp_global_get, "httr2_request")
 
+  tags <- list(custom_tags = list(list(key = "team", value = "data")))
+
   resp_create <- db_sql_warehouse_create(
     name = "brickster_test_warehouse",
     cluster_size = "2X-Small",
     enable_serverless_compute = TRUE,
+    tags = tags,
     perform_request = FALSE
   )
   expect_s3_class(resp_create, "httr2_request")
+  expect_identical(resp_create$body$data$tags, tags)
 
   resp_get <- db_sql_warehouse_get(
     id = "some_warehouse_id",
@@ -34,13 +37,15 @@ test_that("Warehouse API - don't perform", {
   resp_edit <- db_sql_warehouse_edit(
     id = "some_warehouse_id",
     name = "some_warehouse_name",
-    cluster_size =  "2X-Small",
+    cluster_size = "2X-Small",
     spot_instance_policy = "COST_OPTIMIZED",
     channel = "CHANNEL_NAME_CURRENT",
     warehouse_type = "PRO",
+    tags = tags,
     perform_request = FALSE
   )
   expect_s3_class(resp_edit, "httr2_request")
+  expect_identical(resp_edit$body$data$tags, tags)
 
   resp_start <- db_sql_warehouse_start(
     id = "some_warehouse_id",
@@ -53,15 +58,13 @@ test_that("Warehouse API - don't perform", {
     perform_request = FALSE
   )
   expect_s3_class(resp_delete, "httr2_request")
-
 })
 
 skip_on_cran()
 skip_unless_authenticated()
 skip_unless_aws_workspace()
 
 test_that("Warehouse API", {
-
   random_id <- sample.int(100000, 1)
 
   expect_no_error({
@@ -138,5 +141,4 @@ test_that("Warehouse API", {
   })
   expect_type(resp_delete, "list")
   expect_length(resp_delete, 0L)
-
 })