Skip to content

Commit fa4784a

Browse files
committed
fixesadded for fmt
1 parent 2fd5e5f commit fa4784a

File tree

1 file changed

+21
-14
lines changed

1 file changed

+21
-14
lines changed

tests/integration/test_dataset_checks.py

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
is_aggr_not_equal,
1818
foreign_key,
1919
compare_datasets,
20+
DatasetComparisonConfig,
2021
is_data_fresh_per_time_window,
2122
has_valid_schema,
2223
)
@@ -550,7 +551,7 @@ def test_dataset_compare(spark: SparkSession, set_utc_timezone):
550551
columns=columns,
551552
ref_columns=columns,
552553
ref_df_name="df_ref",
553-
check_missing_records=False,
554+
config=DatasetComparisonConfig(check_missing_records=False),
554555
)
555556

556557
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -659,8 +660,10 @@ def test_compare_datasets_with_diff_col_names_and_check_missing(spark: SparkSess
659660
columns=columns,
660661
ref_columns=ref_columns,
661662
ref_df_name="df_ref",
662-
check_missing_records=True,
663-
exclude_columns=[F.col("score")],
663+
config=DatasetComparisonConfig(
664+
check_missing_records=True,
665+
exclude_columns=[F.col("score")],
666+
),
664667
)
665668

666669
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -863,7 +866,7 @@ def test_dataset_compare_ref_as_table_and_skip_map_col(spark: SparkSession, set_
863866
columns=columns,
864867
ref_columns=columns,
865868
ref_table=ref_table,
866-
check_missing_records=False,
869+
config=DatasetComparisonConfig(check_missing_records=False),
867870
)
868871

869872
actual: DataFrame = apply(df, spark, {})
@@ -955,7 +958,7 @@ def test_dataset_compare_with_no_columns_to_compare_and_check_missing(spark: Spa
955958
columns=columns,
956959
ref_columns=columns,
957960
ref_df_name="df_ref",
958-
check_missing_records=True,
961+
config=DatasetComparisonConfig(check_missing_records=True),
959962
)
960963

961964
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -988,7 +991,7 @@ def test_dataset_compare_with_empty_ref_and_check_missing(spark: SparkSession):
988991
columns=columns,
989992
ref_columns=columns,
990993
ref_df_name="df_ref",
991-
check_missing_records=True,
994+
config=DatasetComparisonConfig(check_missing_records=True),
992995
)
993996

994997
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -1042,7 +1045,7 @@ def test_dataset_compare_with_empty_df_and_check_missing(spark: SparkSession):
10421045
columns=columns,
10431046
ref_columns=columns,
10441047
ref_df_name="df_ref",
1045-
check_missing_records=True,
1048+
config=DatasetComparisonConfig(check_missing_records=True),
10461049
)
10471050

10481051
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -1097,7 +1100,7 @@ def test_dataset_compare_with_empty_df_and_ref(spark: SparkSession):
10971100
columns=columns,
10981101
ref_columns=columns,
10991102
ref_df_name="df_ref",
1100-
check_missing_records=True,
1103+
config=DatasetComparisonConfig(check_missing_records=True),
11011104
)
11021105

11031106
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -1155,7 +1158,7 @@ def test_dataset_compare_unsorted_df_columns(spark: SparkSession):
11551158
columns=columns,
11561159
ref_columns=columns, # columns are matched by position, so the order of columns must align exactly
11571160
ref_df_name="df_ref",
1158-
check_missing_records=True,
1161+
config=DatasetComparisonConfig(check_missing_records=True),
11591162
)
11601163

11611164
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -1204,9 +1207,11 @@ def test_compare_dataset_disabled_null_safe_row_matching(spark: SparkSession):
12041207
columns=columns,
12051208
ref_columns=columns, # columns are matched by position, so the order of columns must align exactly
12061209
ref_df_name="df_ref",
1207-
check_missing_records=True,
1208-
null_safe_row_matching=False,
1209-
null_safe_column_value_matching=True,
1210+
config=DatasetComparisonConfig(
1211+
check_missing_records=True,
1212+
null_safe_row_matching=False,
1213+
null_safe_column_value_matching=True,
1214+
),
12101215
)
12111216

12121217
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})
@@ -1304,8 +1309,10 @@ def test_compare_dataset_disabled_null_safe_column_value_matching(spark: SparkSe
13041309
columns=columns,
13051310
ref_columns=columns,
13061311
ref_df_name="df_ref",
1307-
check_missing_records=True,
1308-
null_safe_column_value_matching=False,
1312+
config=DatasetComparisonConfig(
1313+
check_missing_records=True,
1314+
null_safe_column_value_matching=False,
1315+
),
13091316
)
13101317

13111318
actual: DataFrame = apply(df, spark, {"df_ref": df_ref})

0 commit comments

Comments
 (0)