refactor: remove unused participant confirmation and protocol completion functions

Author: YukiTsuchida

src/core/CrossStore.sol

@@ -104,21 +104,6 @@ abstract contract CrossStore {
         compact.ackMask = _uint32ArrayToMask(data.acks);
     }
 
-    function _confirmParticipant(bytes32 txID) internal {
-        _getCoordStorage().compactStates[txID].confirmedMask |= 0x02;
-    }
-
-    function _completeSimpleProtocol(
-        bytes32 txID,
-        CoordinatorState.CoordinatorPhase phase,
-        CoordinatorState.CoordinatorDecision decision
-    ) internal {
-        CoordStateCompact storage compact = _getCoordStorage().compactStates[txID];
-        compact.phase = phase;
-        compact.decision = decision;
-        compact.ackMask |= 0x03;
-    }
-
     function _maskToUint32Array(uint8 mask) internal pure returns (uint32[] memory) {
         uint256 count = 0;
         if ((mask & 0x01) != 0) ++count;

src/core/TxAtomicSimple.sol

@@ -352,9 +352,7 @@ abstract contract TxAtomicSimple is
         }
 
         // Mark Participant prepare as confirmed
-        if (!_containsUint32(cs.confirmed_txs, TX_INDEX_PARTICIPANT)) {
-            _confirmParticipant(txID);
-        }
+        cs.confirmed_txs = _addToUint32Array(cs.confirmed_txs, TX_INDEX_PARTICIPANT);
 
         // --- 5. Determine Commit/Abort based on ACK ---
 
@@ -373,16 +371,10 @@ abstract contract TxAtomicSimple is
         cs.phase = CoordinatorState.CoordinatorPhase.COORDINATOR_PHASE_COMMIT;
 
         // Set ACK flags
-        CoordinatorState.CoordinatorDecision decision;
-        if (ack.status == PacketAcknowledgementCall.CommitStatus.COMMIT_STATUS_OK) {
-            decision = CoordinatorState.CoordinatorDecision.COORDINATOR_DECISION_COMMIT;
-        } else {
-            decision = CoordinatorState.CoordinatorDecision.COORDINATOR_DECISION_ABORT;
-        }
-
-        _completeSimpleProtocol(txID, CoordinatorState.CoordinatorPhase.COORDINATOR_PHASE_COMMIT, decision);
+        cs.acks = _addToUint32Array(cs.acks, TX_INDEX_COORDINATOR);
+        cs.acks = _addToUint32Array(cs.acks, TX_INDEX_PARTICIPANT);
 
-        cs = _loadCoordinatorState(txID);
+        _saveCoordinatorState(txID, cs);
 
         bool allPrepares =
             _containsUint32(cs.confirmed_txs, TX_INDEX_COORDINATOR)
@@ -463,6 +455,18 @@ abstract contract TxAtomicSimple is
         return false;
     }
 
+    function _addToUint32Array(uint32[] memory arr, uint32 val) internal view returns (uint32[] memory) {
+        if (_containsUint32(arr, val)) {
+            return arr;
+        }
+        uint32[] memory newArr = new uint32[](arr.length + 1);
+        for (uint256 i = 0; i < arr.length; i++) {
+            newArr[i] = arr[i];
+        }
+        newArr[arr.length] = val;
+        return newArr;
+    }
+
     function packPacketAcknowledgementCall(PacketAcknowledgementCall.Data memory ack)
         internal
         pure

test/CrossStore.t.sol

@@ -50,18 +50,6 @@ contract CrossStoreHarness is CrossStore {
         _saveCoordinatorState(txID, data);
     }
 
-    function exposed_confirmParticipant(bytes32 txID) public {
-        _confirmParticipant(txID);
-    }
-
-    function exposed_completeSimpleProtocol(
-        bytes32 txID,
-        CoordinatorState.CoordinatorPhase phase,
-        CoordinatorState.CoordinatorDecision decision
-    ) public {
-        _completeSimpleProtocol(txID, phase, decision);
-    }
-
     function exposed_maskToUint32Array(uint8 mask) public pure returns (uint32[] memory) {
         return _maskToUint32Array(mask);
     }
@@ -268,32 +256,4 @@ contract CrossStoreTest is Test {
             acks: new uint32[](0)
         });
     }
-
-    function test_confirmParticipant_UpdatesMask() public {
-        bytes32 txId = keccak256("tx.confirm");
-
-        test_SaveAndLoad_CoordinatorState();
-        txId = keccak256("tx.save.load");
-
-        harness.exposed_confirmParticipant(txId);
-
-        CoordinatorState.Data memory loaded = harness.exposed_loadCoordinatorState(txId);
-        assertEq(loaded.confirmed_txs.length, 2, "Should have 2 confirmed txs");
-        assertEq(loaded.confirmed_txs[1], 1, "Participant should be confirmed");
-    }
-
-    function test_completeSimpleProtocol_SetsCorrectValues() public {
-        bytes32 txId = keccak256("tx.complete");
-
-        harness.exposed_completeSimpleProtocol(
-            txId,
-            CoordinatorState.CoordinatorPhase.COORDINATOR_PHASE_COMMIT,
-            CoordinatorState.CoordinatorDecision.COORDINATOR_DECISION_COMMIT
-        );
-
-        CoordinatorState.Data memory loaded = harness.exposed_loadCoordinatorState(txId);
-        assertEq(uint256(loaded.phase), uint256(CoordinatorState.CoordinatorPhase.COORDINATOR_PHASE_COMMIT));
-        assertEq(uint256(loaded.decision), uint256(CoordinatorState.CoordinatorDecision.COORDINATOR_DECISION_COMMIT));
-        assertEq(loaded.acks.length, 2, "Both Coord and Participant should be in ACKs");
-    }
 }