feat: add TxAuthCompleted event emission in Authenticator contract

Author: YukiTsuchida

src/core/Authenticator.sol

@@ -36,6 +36,9 @@ abstract contract Authenticator is IAuthenticator, TxAuthManagerBase, TxManagerB
         Account.Data[] memory accounts = _buildLocalAccounts(msg_.signers);
 
         bool completed = _sign(txID, accounts);
+        if (completed) {
+            emit TxAuthCompleted(txID);
+        }
 
         emit TxSigned(msg.sender, txID, AuthType.AuthMode.AUTH_MODE_LOCAL);
 
@@ -47,7 +50,10 @@ abstract contract Authenticator is IAuthenticator, TxAuthManagerBase, TxManagerB
 
         _verifySignatures(txID, msg_.signers);
 
-        _sign(txID, msg_.signers);
+        bool completed = _sign(txID, msg_.signers);
+        if (completed) {
+            emit TxAuthCompleted(txID);
+        }
 
         emit TxSigned(msg.sender, txID, AuthType.AuthMode.AUTH_MODE_EXTENSION);
 

src/core/ICrossEvent.sol

@@ -9,6 +9,7 @@ interface ICrossEvent {
     event OnCommit(bytes indexed txID, uint8 indexed txIndex);
     event OnAbort(bytes indexed txID, uint8 indexed txIndex);
     event TxSigned(address indexed signer, bytes32 indexed txID, AuthType.AuthMode method);
+    event TxAuthCompleted(bytes32 indexed txID);
     event TxInitiated(bytes txID, address indexed proposer, MsgInitiateTx.Data msgData);
     event TxExecuted(bytes txID, address indexed proposer);
 }

test/Authenticator.t.sol

@@ -209,7 +209,10 @@ contract AuthenticatorTest is Test, ICrossError, ICrossEvent {
     function test_signTx_SucceedsAsCompletedAndEmitsEvent() public {
         harness.setSignReturns(true);
 
-        vm.expectEmit(true, true, false, true, address(harness));
+        vm.expectEmit(address(harness));
+        emit TxAuthCompleted(txID);
+
+        vm.expectEmit(address(harness));
         emit TxSigned(address(this), txID, AuthType.AuthMode.AUTH_MODE_LOCAL);
 
         MsgSignTxResponse.Data memory resp = harness.signTx(baseMsg);
@@ -267,6 +270,9 @@ contract AuthenticatorTest is Test, ICrossError, ICrossEvent {
     function test_extSignTx_SucceedsAsCompletedAndEmitsEvent() public {
         harness.setSignReturns(true);
 
+        vm.expectEmit(address(harness));
+        emit TxAuthCompleted(extTxID);
+
         vm.expectEmit(address(harness));
         emit TxSigned(address(this), extTxID, AuthType.AuthMode.AUTH_MODE_EXTENSION);