Skip to content

Commit eae5bdb

Browse files
committed
fix: solhint
1 parent 16e1764 commit eae5bdb

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/core/Authenticator.sol

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ pragma solidity ^0.8.20;
44
import {IAuthenticator} from "./IAuthenticator.sol";
55
import {TxAuthManagerBase} from "./TxAuthManager.sol";
66
import {TxManagerBase} from "./TxManagerBase.sol";
7-
import {IAuthExtensionVerifier} from "./IAuthExtensionVerifier.sol";
87

98
import {
109
AuthType,
@@ -14,8 +13,7 @@ import {
1413
MsgExtSignTxResponse,
1514
QueryTxAuthStateRequest,
1615
QueryTxAuthStateResponse,
17-
Account,
18-
TxAuthState
16+
Account
1917
} from "../proto/cross/core/auth/Auth.sol";
2018
import {GoogleProtobufAny} from "@hyperledger-labs/yui-ibc-solidity/contracts/proto/GoogleProtobufAny.sol";
2119

src/core/TxAuthManager.sol

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ import {IAuthExtensionVerifier} from "./IAuthExtensionVerifier.sol";
88

99
abstract contract TxAuthManager is TxAuthManagerBase, CrossStore {
1010
constructor(string[] memory typeUrls, IAuthExtensionVerifier[] memory verifiers) {
11-
require(typeUrls.length == verifiers.length, "TxAuthManager: array mismatch");
11+
if (typeUrls.length != verifiers.length) revert ArrayLengthMismatch();
1212

1313
CrossStore.AuthStorage storage s = _getAuthStorage();
1414

15-
for (uint256 i = 0; i < typeUrls.length; i++) {
15+
for (uint256 i = 0; i < typeUrls.length; ++i) {
1616
string memory typeUrl = typeUrls[i];
1717
IAuthExtensionVerifier verifier = verifiers[i];
1818

19-
require(bytes(typeUrl).length > 0, "TxAuthManager: empty typeUrl");
20-
require(address(verifier) != address(0), "TxAuthManager: zero address verifier");
19+
if (bytes(typeUrl).length == 0) revert EmptyTypeUrl();
20+
if (address(verifier) == address(0)) revert ZeroAddressVerifier();
2121

2222
s.authVerifiers[typeUrl] = verifier;
2323
emit VerifierRegistered(typeUrl, address(verifier));
@@ -91,7 +91,7 @@ abstract contract TxAuthManager is TxAuthManagerBase, CrossStore {
9191

9292
CrossStore.AuthStorage storage s = _getAuthStorage();
9393

94-
for (uint256 i = 0; i < signers.length; i++) {
94+
for (uint256 i = 0; i < signers.length; ++i) {
9595
Account.Data calldata signer = signers[i];
9696

9797
if (signer.auth_type.mode != AuthType.AuthMode.AUTH_MODE_EXTENSION) {

src/core/TxAuthManagerBase.sol

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,11 @@ abstract contract TxAuthManagerBase {
1111
error AuthModeMismatch();
1212
error VerifierNotFound(string typeUrl);
1313
error SignatureVerificationFailed(bytes32 txID);
14+
error ArrayLengthMismatch();
15+
error EmptyTypeUrl();
16+
error ZeroAddressVerifier();
1417

15-
event VerifierRegistered(string typeUrl, address verifier);
18+
event VerifierRegistered(string typeUrl, address indexed verifier);
1619

1720
function initAuthState(bytes32 txID, Account.Data[] memory signers) internal virtual;
1821
function isCompletedAuth(bytes32 txID) internal view virtual returns (bool);

test/Authenticator.t.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {TxAuthManagerBase} from "../src/core/TxAuthManagerBase.sol";
99

1010
import {MsgInitiateTx} from "../src/proto/cross/core/initiator/Initiator.sol";
1111
import {IAuthenticator} from "../src/core/IAuthenticator.sol";
12-
import {IAuthExtensionVerifier} from "../src/core/IAuthExtensionVerifier.sol";
1312
import {
1413
Account as AuthAccount,
1514
AuthType,

0 commit comments

Comments
 (0)