Skip to content

Commit 14753f8

Browse files
committed
rename init_quote with get_qe_target_info
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
1 parent 9044f9b commit 14753f8

File tree

6 files changed

+19
-11
lines changed

6 files changed

+19
-11
lines changed

app/src/commands/enclave.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ fn run_generate_key<E: EnclaveCommandAPI<S>, S: CommitStore>(
9191
enclave: E,
9292
input: &GenerateKey,
9393
) -> Result<()> {
94-
let (target_info, _) = remote_attestation::init_quote(input.target_qe)?;
94+
let (target_info, _) = remote_attestation::get_target_qe_info(input.target_qe)?;
9595
let res = enclave
9696
.generate_enclave_key(
9797
GenerateEnclaveKeyInput {

modules/remote-attestation/src/common.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,15 @@ use sgx_types::{
55
sgx_target_info_t,
66
};
77

8-
pub fn init_quote(
8+
/// Get target QE info
9+
///
10+
/// # Arguments
11+
/// - `target_qe_type` - QE type(QE, QE3, QE3SIM)
12+
///
13+
/// # Returns
14+
/// - `sgx_target_info_t` - Target info
15+
/// - `sgx_epid_group_id_t` - If `target_qe_type` is QE, return epid group id. Otherwise, return default value
16+
pub fn get_target_qe_info(
917
target_qe_type: QEType,
1018
) -> Result<(sgx_target_info_t, sgx_epid_group_id_t), Error> {
1119
let mut target_info = sgx_target_info_t::default();

modules/remote-attestation/src/ias.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use crate::common::init_quote;
1+
use crate::common::get_target_qe_info;
22
use crate::errors::Error;
33
use crate::ias_utils::{
44
decode_spid, get_quote, get_report_from_intel, get_sigrl_from_intel, validate_qe_report,
@@ -27,7 +27,7 @@ pub fn run_ias_ra(
2727
}
2828

2929
let spid = decode_spid(&spid)?;
30-
let (target_info, epid_group_id) = init_quote(QEType::QE)?;
30+
let (target_info, epid_group_id) = get_target_qe_info(QEType::QE)?;
3131
// Now sigrl is the revocation list, a vec<u8>
3232
let sigrl = get_sigrl_from_intel(mode, epid_group_id, &ias_key)?;
3333
let (quote, qe_report) = get_quote(sigrl, ek_info.report, SGX_QUOTE_SIGN_TYPE, spid)?;

modules/remote-attestation/src/ias_simulation.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use crate::errors::Error;
2+
use crate::get_target_qe_info;
23
use crate::ias_utils::{get_quote, validate_qe_report, SGX_QUOTE_SIGN_TYPE};
3-
use crate::init_quote;
44
use attestation_report::{IASAttestationVerificationReport, IASSignedReport, QEType};
55
use base64::{engine::general_purpose::STANDARD as Base64Std, Engine};
66
use crypto::Address;
@@ -17,7 +17,7 @@ pub fn run_ias_ra_simulation(
1717
signing_key: rsa::pkcs1v15::SigningKey<sha2::Sha256>,
1818
signing_cert: Vec<u8>,
1919
) -> Result<IASSignedReport, Error> {
20-
let (target_info, _) = init_quote(QEType::QE)?;
20+
let (target_info, _) = get_target_qe_info(QEType::QE)?;
2121
let ek_info = key_manager.load(target_enclave_key).map_err(|e| {
2222
Error::key_manager(
2323
format!("cannot load enclave key: {}", target_enclave_key),

modules/remote-attestation/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub mod ias_simulation;
1010
mod ias_utils;
1111
pub mod zkdcap;
1212

13-
pub use common::init_quote;
13+
pub use common::get_target_qe_info;
1414
pub use dcap_pcs;
1515
pub use ias_utils::{validate_qe_report, IASMode, IAS_HOSTNAME};
1616
#[cfg(feature = "sgx-sw")]

tests/integration/src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ mod tests {
8080
info!("this test is running in HW mode");
8181
}
8282

83-
let (qe_target_info, _) = remote_attestation::init_quote(QEType::QE)?;
83+
let (qe_target_info, _) = remote_attestation::get_target_qe_info(QEType::QE)?;
8484
let operator = Address::from_hex_string("0x396e1ccc2f11cd6d2114c2449dad7751357e413e")?;
8585
let op_ek_addr = match enclave.generate_enclave_key(
8686
GenerateEnclaveKeyInput {
@@ -192,7 +192,7 @@ mod tests {
192192
use remote_attestation::zkvm::prover::Risc0ProverMode;
193193
use zkdcap_risc0::DCAP_QUOTE_VERIFIER_ELF;
194194

195-
let target_info = remote_attestation::init_quote(QEType::QE3SIM)?.0;
195+
let target_info = remote_attestation::get_target_qe_info(QEType::QE3SIM)?.0;
196196
let zkdcap_ek_addr = match enclave.generate_enclave_key(
197197
GenerateEnclaveKeyInput {
198198
operator: Some(operator),
@@ -230,7 +230,7 @@ mod tests {
230230
use remote_attestation::zkvm::prover::Risc0ProverMode;
231231
use zkdcap_risc0::DCAP_QUOTE_VERIFIER_ELF;
232232

233-
let target_info = remote_attestation::init_quote(QEType::QE3)?.0;
233+
let target_info = remote_attestation::get_target_qe_info(QEType::QE3)?.0;
234234
let zkdcap_ek_addr = match enclave.generate_enclave_key(
235235
GenerateEnclaveKeyInput {
236236
operator: Some(operator),
@@ -296,7 +296,7 @@ mod tests {
296296
enclave: &Enclave<store::memory::MemStore>,
297297
) -> Result<(), anyhow::Error> {
298298
let operator = Address::from_hex_string("0x396e1ccc2f11cd6d2114c2449dad7751357e413e")?;
299-
let (target_info, _) = remote_attestation::init_quote(QEType::QE)?;
299+
let (target_info, _) = remote_attestation::get_target_qe_info(QEType::QE)?;
300300
let signer = match enclave.generate_enclave_key(
301301
GenerateEnclaveKeyInput {
302302
operator: Some(operator),

0 commit comments

Comments
 (0)