fix clippy

Author: yoshidan

derivation/src/oracle.rs

@@ -314,7 +314,7 @@ mod test {
     fn test_verify_blob_preimage_error() {
         let mut blob_key = [0u8; POSITION_FIELD_ELEMENT + 8];
         let blob_key_hash = keccak256(blob_key);
-        let mut final_kzg_proof_key = blob_key.clone();
+        let mut final_kzg_proof_key = blob_key;
         final_kzg_proof_key[POSITION_FIELD_ELEMENT..]
             .copy_from_slice((FIELD_ELEMENTS_PER_BLOB).to_be_bytes().as_ref());
         let final_kzg_proof = [0u8; BYTES_PER_COMMITMENT];

light-client/src/client.rs

@@ -295,7 +295,7 @@ mod test {
 
     impl HostContext for MockClientReader {
         fn host_timestamp(&self) -> Time {
-            self.time.unwrap_or_else(|| Time::now())
+            self.time.unwrap_or_else(Time::now)
         }
     }
 
@@ -445,7 +445,7 @@ mod test {
         let (cs, cons_state) = get_initial_state();
 
         let mut cons_states = BTreeMap::new();
-        cons_states.insert(cs.latest_height.clone(), cons_state);
+        cons_states.insert(cs.latest_height, cons_state);
 
         let client_message =
             std::fs::read("../testdata/update_client_header.bin").expect("file not found");
@@ -473,7 +473,7 @@ mod test {
 
         let mut cons_states = BTreeMap::new();
         cons_states.insert(
-            proof_height.clone(),
+            proof_height,
             ConsensusState {
                 storage_root: H256(hex!(
                     "27cd08827e6bf1e435832f4b2660107beb562314287b3fa534f3b189574c0cca"
@@ -488,7 +488,7 @@ mod test {
                 ibc_commitments_slot: H256(hex!(
                     "1ee222554989dda120e26ecacf756fe1235cd8d726706b57517715dde4f0c900"
                 )),
-                latest_height: proof_height.clone(),
+                latest_height: proof_height,
                 ..Default::default()
             }),
             consensus_state: cons_states,
@@ -517,7 +517,7 @@ mod test {
 
         let mut cons_states = BTreeMap::new();
         cons_states.insert(
-            proof_height.clone(),
+            proof_height,
             ConsensusState {
                 storage_root: H256(hex!(
                     "27cd08827e6bf1e435832f4b2660107beb562314287b3fa534f3b189574c0cca"
@@ -532,7 +532,7 @@ mod test {
                 ibc_commitments_slot: H256(hex!(
                     "1ee222554989dda120e26ecacf756fe1235cd8d726706b57517715dde4f0c900"
                 )),
-                latest_height: proof_height.clone(),
+                latest_height: proof_height,
                 ..Default::default()
             }),
             consensus_state: cons_states,

light-client/src/l1.rs

@@ -563,11 +563,11 @@ pub(crate) mod tests {
     ) -> L1Header<{ ethereum_consensus::preset::minimal::PRESET.SYNC_COMMITTEE_SIZE }> {
         // created by optimism-ibc-relay-prover
         let raw_l1_header = get_raw_l1_header();
-        let l1_header = L1Header::<
-            { ethereum_consensus::preset::minimal::PRESET.SYNC_COMMITTEE_SIZE },
-        >::try_from(raw_l1_header.clone())
-        .unwrap();
-        l1_header
+
+        L1Header::<{ ethereum_consensus::preset::minimal::PRESET.SYNC_COMMITTEE_SIZE }>::try_from(
+            raw_l1_header.clone(),
+        )
+        .unwrap()
     }
 
     pub fn get_l1_consensus() -> L1Consensus {
@@ -705,7 +705,7 @@ pub(crate) mod tests {
         let cons_state = get_l1_consensus();
         let mut l1_header = get_l1_header();
         l1_header.consensus_update.finalized_header.0.slot =
-            (l1_header.consensus_update.finalized_header.0.slot + 32).into();
+            l1_header.consensus_update.finalized_header.0.slot + 32;
         l1_header.consensus_update.next_sync_committee = None;
 
         let err = apply_updates(&ctx, &cons_state, &l1_header.consensus_update).unwrap_err();