Merge pull request #960 from datacite/remove-password-generation

Remove automatic password generation

Author: digitaldogsbody

app/controllers/change.js

@@ -31,29 +31,6 @@ export default class ChangeController extends Controller {
     togglePassword.classList.toggle('bi-eye');
   }
 
-  @action
-  generate() {
-    let self = this;
-    let url = ENV.API_URL + '/random';
-    fetch(url, {
-      headers: {
-        Authorization: 'Bearer ' + this.currentUser.get('jwt')
-      }
-    })
-      .then(function (response) {
-        if (response.ok) {
-          response.json().then(function (data) {
-            self.get('model').set('passwordInput', data.phrase);
-          });
-        } else {
-          console.debug(response);
-        }
-      })
-      .catch(function (error) {
-        console.debug(error);
-      });
-  }
-
   @action
   submitAction(provider) {
     let self = this;

app/controllers/password.js

@@ -54,27 +54,4 @@ export default class PasswordController extends Controller {
       self.router.transitionTo('index');
     });
   }
-
-  @action
-  generate() {
-    let self = this;
-    let url = ENV.API_URL + '/random';
-    fetch(url, {
-      headers: {
-        Authorization: 'Bearer ' + this.currentUser.get('jwt')
-      }
-    })
-      .then(function (response) {
-        if (response.ok) {
-          response.json().then(function (data) {
-            self.get('model').set('passwordInput', data.phrase);
-          });
-        } else {
-          console.debug(response);
-        }
-      })
-      .catch(function (error) {
-        console.debug(error);
-      });
-  }
 }

app/controllers/providers/show/change.js

@@ -31,29 +31,6 @@ export default class ChangeController extends Controller {
     togglePassword.classList.toggle('bi-eye');
   }
 
-  @action
-  generate() {
-    let self = this;
-    let url = ENV.API_URL + '/random';
-    fetch(url, {
-      headers: {
-        Authorization: 'Bearer ' + this.currentUser.get('jwt')
-      }
-    })
-      .then(function (response) {
-        if (response.ok) {
-          response.json().then(function (data) {
-            self.get('model').set('passwordInput', data.phrase);
-          });
-        } else {
-          console.debug(response);
-        }
-      })
-      .catch(function (error) {
-        console.debug(error);
-      });
-  }
-
   @action
   submitAction() {
     let self = this;

app/controllers/repositories/show/change.js

@@ -31,29 +31,6 @@ export default class ChangeController extends Controller {
     togglePassword.classList.toggle('bi-eye');
   }
 
-  @action
-  generateAction() {
-    let self = this;
-    let url = ENV.API_URL + '/random';
-    fetch(url, {
-      headers: {
-        Authorization: 'Bearer ' + this.currentUser.get('jwt')
-      }
-    })
-      .then(function (response) {
-        if (response.ok) {
-          response.json().then(function (data) {
-            self.get('model').set('passwordInput', data.phrase);
-          });
-        } else {
-          console.debug(response);
-        }
-      })
-      .catch(function (error) {
-        console.debug(error);
-      });
-  }
-
   @action
   submitAction(repository) {
     let self = this;

app/templates/change.hbs

@@ -8,9 +8,7 @@
       <div class="panel panel-transparent">
         <div class="panel-body">
           <div class="col-md-9 col-md-offset-3"><h3 class="edit">Set Password</h3></div>
-
-          <div class="col-md-9 col-md-offset-3"><span class="help-block">Click <a class="action-link" {{action "generate"}} data-test-password-suggestion>here</a> for a password suggestion.</span></div>
-
+          
           <BsForm @formLayout="horizontal" class="form-horizontal" @horizontalLabelGridClass="col-md-3" @model={{this.model}} @onSubmit={{action "submitAction" this.model}} @submitOnEnter={{true}} as |form|>
             <form.element @controlType="password" id="password-input" class="form-group" @property="passwordInput" @label="New Password" as |el|> <el.control id="password-input-field" /><i class="bi bi-eye-slash" id="togglePassword" {{action 'togglePassword'}}></i></form.element>
             <form.element @controlType="password" id="confirm-password-input" class="form-group" @property="confirmPasswordInput" @label="Confirm Password" as |el|> <el.control id="confirm-password-input-field" /><i class="bi bi-eye-slash" id="toggleConfirmPassword" {{action 'toggleConfirmPassword'}}></i></form.element>

app/templates/password.hbs

@@ -13,17 +13,6 @@
             <h3 class="title">
               Set Password
             </h3>
-            <span class="help-block">
-              Click
-              <a
-                class="action-link"
-                data-test-password-suggestion
-                {{action 'generate'}}
-              >
-                here
-              </a>
-              for a password suggestion.
-            </span>
             <BsForm
               @formLayout="vertical"
               @model={{this.model}}

app/templates/providers/show/change.hbs

@@ -2,8 +2,6 @@
   <div class="panel-body">
     <div class="col-md-9 col-md-offset-3"><h3 class="edit">Set Password</h3></div>
 
-    <div class="col-md-9 col-md-offset-3"><span class="help-block">Click <a class="action-link" {{action "generate"}} data-test-password-suggestion>here</a> for a password suggestion.</span></div>
-
     <BsForm @formLayout="horizontal" class="form-horizontal" @horizontalLabelGridClass="col-md-3" @model={{this.model}} @onSubmit={{action "submitAction"}} @submitOnEnter={{true}} as |form|>
       <form.element @controlType="password" id="password-input" class="form-group" @property="passwordInput" @label="New Password" as |el| >
         <el.control id="password-input-field" /><i class="bi bi-eye-slash" id="togglePassword" {{action 'togglePassword'}}></i>

app/templates/repositories/show/change.hbs

@@ -2,8 +2,6 @@
     <div class="panel-body">
       <div class="col-md-9 col-md-offset-3">
         <h3 class="edit">Set Password</h3>
-
-        <span class="help-block">Click <a class="action-link" {{action "generateAction"}} data-test-password-suggestion>here</a> for a password suggestion.</span>
       </div>
 
       <BsForm @formLayout="horizontal" class="form-horizontal" @horizontalLabelGridClass="col-md-3" @model={{this.model}} @onSubmit={{action "submitAction"}} @submitOnEnter={{true}} as |form|>