Merge pull request #29 from datacite/add-event-model-specs

Add event model specs

Author: wendelfabianchinsamy

Gemfile

@@ -46,4 +46,5 @@ end
 
 group :test do
   gem "simplecov", require: false
+  gem "shoulda-matchers"
 end

Gemfile.lock

@@ -337,6 +337,8 @@ GEM
       aws-sdk-core (>= 2)
       concurrent-ruby
       thor
+    shoulda-matchers (6.5.0)
+      activesupport (>= 5.2.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -400,6 +402,7 @@ DEPENDENCIES
   sentry-rails
   sentry-ruby
   shoryuken (~> 4.0)
+  shoulda-matchers
   simplecov
   uuid (~> 2.3, >= 2.3.9)
 

app/models/event.rb

@@ -42,11 +42,21 @@ class Event < ApplicationRecord
 
   # Getters
   def subj_hash
-    @subj_hash ||= JSON.parse(subj)
+    return {} if subj.blank?
+
+    JSON.parse(subj)
+  rescue => e
+    Rails.logger.error("JSON parsing failed for event.subj: #{e.message}")
+    {}
   end
 
   def obj_hash
-    @obj_hash ||= JSON.parse(obj)
+    return {} if obj.blank?
+
+    JSON.parse(obj)
+  rescue => e
+    Rails.logger.error("JSON parsing failed for event.obj: #{e.message}")
+    {}
   end
 
   # Callback Hooks