Merge pull request #22 from datacite/add-constants-relation-types-specs

Add constants relation_types specs

Author: wendelfabianchinsamy

.rubocop.yml

@@ -30,3 +30,6 @@ Style/StringLiteralsInInterpolation:
 
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: true
+
+RSpec/ExampleLength:
+  Enabled: false

app/models/concerns/relation_type_handler.rb

@@ -4,19 +4,18 @@
 # Method is only invoked via a before_validation callback in the events model.
 
 module RelationTypeHandler
-  include RelationTypes
   extend ActiveSupport::Concern
 
   def set_source_and_target_doi!
     return if subj_id.blank? || obj_id.blank?
 
     case relation_type_id
-    when *REFERENCE_RELATION_TYPES
+    when *RelationTypes::REFERENCE_RELATION_TYPES
       self.source_doi = DoiUtilities.uppercase_doi_from_url(subj_id)
       self.target_doi = DoiUtilities.uppercase_doi_from_url(obj_id)
       self.source_relation_type_id = "references"
       self.target_relation_type_id = "citations"
-    when *CITATION_RELATION_TYPES
+    when *RelationTypes::CITATION_RELATION_TYPES
       self.source_doi = DoiUtilities.uppercase_doi_from_url(obj_id)
       self.target_doi = DoiUtilities.uppercase_doi_from_url(subj_id)
       self.source_relation_type_id = "references"

spec/constants/relation_type_spec.rb

@@ -0,0 +1,96 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe("RelationType") do
+  describe "Constants" do
+    it "defines REFERENCE_RELATION_TYPES correctly" do
+      expected = ["cites", "is-supplemented-by", "references"]
+
+      expect(RelationTypes::REFERENCE_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines CITATION_RELATION_TYPES correctly" do
+      expected = ["is-cited-by", "is-supplement-to", "is-referenced-by"]
+
+      expect(RelationTypes::CITATION_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines INCLUDED_RELATION_TYPES as the union of REFERENCE_RELATION_TYPES and CITATION_RELATION_TYPES" do
+      expected = RelationTypes::REFERENCE_RELATION_TYPES | RelationTypes::CITATION_RELATION_TYPES
+
+      expect(RelationTypes::INCLUDED_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines PART_RELATION_TYPES correctly" do
+      expected = ["is-part-of", "has-part"]
+
+      expect(RelationTypes::PART_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines NEW_RELATION_TYPES correctly" do
+      expected = ["is-reply-to", "is-translation-of", "is-published-in"]
+
+      expect(RelationTypes::NEW_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines RELATIONS_RELATION_TYPES correctly" do
+      expected = [
+        "compiles",
+        "is-compiled-by",
+        "documents",
+        "is-documented-by",
+        "has-metadata",
+        "is-metadata-for",
+        "is-derived-from",
+        "is-source-of",
+        "reviews",
+        "is-reviewed-by",
+        "requires",
+        "is-required-by",
+        "continues",
+        "is-coutinued-by",
+        "has-version",
+        "is-version-of",
+        "has-part",
+        "is-part-of",
+        "is-variant-from-of",
+        "is-original-form-of",
+        "is-identical-to",
+        "obsoletes",
+        "is-obsolete-by",
+        "is-new-version-of",
+        "is-previous-version-of",
+        "describes",
+        "is-described-by",
+      ]
+
+      expect(RelationTypes::RELATIONS_RELATION_TYPES).to(eq(expected))
+    end
+
+    it "defines ALL_RELATION_TYPES as the union of all relation types" do
+      expected = (
+        RelationTypes::RELATIONS_RELATION_TYPES |
+        RelationTypes::NEW_RELATION_TYPES |
+        RelationTypes::CITATION_RELATION_TYPES |
+        RelationTypes::REFERENCE_RELATION_TYPES
+      ).uniq
+
+      expect(RelationTypes::ALL_RELATION_TYPES).to(match_array(expected))
+    end
+
+    it "defines OTHER_RELATION_TYPES correctly" do
+      expected = (
+        RelationTypes::RELATIONS_RELATION_TYPES | RelationTypes::NEW_RELATION_TYPES
+      ) - RelationTypes::INCLUDED_RELATION_TYPES - RelationTypes::PART_RELATION_TYPES
+
+      expect(RelationTypes::OTHER_RELATION_TYPES).to(match_array(expected))
+    end
+
+    it "defines RELATED_SOURCE_IDS correctly" do
+      expected = ["datacite-related", "datacite-crossref", "crossref"]
+
+      expect(RelationTypes::RELATED_SOURCE_IDS).to(eq(expected))
+    end
+  end
+end