Add event index handler specs

Author: wendelfabianchinsamy

app/models/concerns/event_index_handler.rb

@@ -55,7 +55,7 @@ def obj_cache_key
     "objects/#{obj_id}-#{timestamp}"
   end
 
-  # QUESTION -> SHOULD THIS ALLOW DUPLICATE VALUES???
+  # TODO: SHOULD THIS ALLOW DUPLICATE VALUES???
   def doi
     # Extract all subj proxy identifiers that match 10.()dot followed by 4 or 5 digits
     # then followed by a slash and finally followed by at least 1 character.
@@ -103,8 +103,16 @@ def issn
       Array.wrap(obj_hash.dig("periodical", "issn")).compact
   end
 
+  # TODO: WHY IS THIS AN ARRAY OF ARRAYS?
+  #       CAN WE CHANGE THIS TO BE A SIMPLE SINGLE ARRAY?
+  # TODO: THE to_s CALL IS DONE BECAUSE OF THE EXISTING BUG
+  #       THAT ALLOWS NULL VALUES. IF WE CHANGE THIS AND CLEAN
+  #       THE DATA WE COULD REMOVE THIS CALL IN THE FUTURE.
   def prefix
-    [doi.map { |d| d.to_s.split("/", 2).first }].compact
+    # Loop through all dois in the doi array
+    # Split each doi at the first slash -> /
+    # And return the first element in that array i.e. the prefix
+    [doi.map { |d| d.split("/", 2).first }].compact
   end
 
   def subtype

spec/models/concerns/event_index_handler_spec.rb

@@ -184,4 +184,37 @@
       expect(event.issn).to(eq([]))
     end
   end
+
+  describe "prefix" do
+    it "when doi has dois returns the prefix of each doi" do
+      event.subj_id = "10.0000/0000"
+      event.obj_id = "10.0001/0001"
+
+      event.subj = {
+        "proxyIdentifiers": ["10.0002/0002"],
+        "funder": [{ "@id": "10.0003/0003" }],
+      }.to_json
+
+      event.obj = {
+        "proxyIdentifiers": ["10.0004/0004"],
+        "funder": [{ "@id": "10.0005/0005" }],
+      }.to_json
+
+      expect(event.prefix.flatten).to(contain_exactly(
+        "10.0000",
+        "10.0001",
+        "10.0002",
+        "10.0003",
+        "10.0004",
+        "10.0005",
+      ))
+    end
+
+    it "when doi is an empty array returns an empty array" do
+      event.subj_id = nil
+      event.obj_id = nil
+
+      expect(event.prefix.flatten).to(eq([]))
+    end
+  end
 end