Skip to content

Commit ee14264

Browse files
Some cleanup
1 parent f9a4d86 commit ee14264

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ jobs:
272272
run: |
273273
cargo test --manifest-path crates/datafusion-udfs-wasm/Cargo.toml
274274
test-auth:
275-
name: Extension / Auth-Basic-Bearer
275+
name: Extension / Auth
276276
runs-on: ubuntu-latest
277277
strategy:
278278
matrix:
@@ -293,6 +293,7 @@ jobs:
293293
key: ${{ runner.os }}-cargo-target-${{ hashFiles('Cargo.lock') }}
294294
- name: Setup Rust Toolchain
295295
uses: ./.github/actions/setup-rust
296+
# Right now basic and bearer auth can not be used at the same time. So we serve an instance with one, then kill it, then serve an instance with another. An alternative, perhaps simpler option, would be configuring the ports used - but this would come at the cost of a more annoying local dev experience as you have to remember to keep updating the ports.
296297
- name: Start FlightSQL Server with Basic Auth
297298
run: |
298299
cargo r --features=flightsql -- serve-flightsql --config data/configs/flightsql_basic.toml & echo $! > server.pid

crates/datafusion-app/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ edition = "2021"
33
name = "datafusion-app"
44
version = "0.1.0"
55

6+
# Leaving Hudi and Iceberg around in case traction on those picks up. It would be better if I just remove them from main and create PRs with the diff - maybe ill get around to that.
7+
68
[dependencies]
79
arrow-flight = { version = "54.1.0", features = [
810
"flight-sql-experimental",

crates/datafusion-app/src/extensions/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ pub fn enabled_extensions() -> Vec<Arc<dyn Extension>> {
6262
Arc::new(deltalake::DeltaLakeExtension::new()),
6363
// #[cfg(feature = "hudi")]
6464
// Arc::new(hudi::HudiExtension::new()),
65-
#[cfg(feature = "iceberg")]
66-
Arc::new(iceberg::IcebergExtension::new()),
65+
// #[cfg(feature = "iceberg")]
66+
// Arc::new(iceberg::IcebergExtension::new()),
6767
#[cfg(feature = "huggingface")]
6868
Arc::new(huggingface::HuggingFaceExtension::new()),
6969
]

0 commit comments

Comments
 (0)