|
| 1 | +#![cfg(feature = "metadata-duckdb")] |
| 2 | +//! Tests for numeric metadata validation (#58, #59) |
| 3 | +//! |
| 4 | +//! Verifies that negative file_size_bytes and footer_size values in catalog |
| 5 | +//! metadata are caught early with clear error messages instead of wrapping |
| 6 | +//! to huge values via unchecked `as u64`/`as usize` casts. |
| 7 | +
|
| 8 | +use std::sync::Arc; |
| 9 | + |
| 10 | +use datafusion::error::Result as DataFusionResult; |
| 11 | +use datafusion::prelude::*; |
| 12 | +use datafusion_ducklake::{DuckLakeCatalog, DuckdbMetadataProvider}; |
| 13 | +use tempfile::TempDir; |
| 14 | + |
| 15 | +/// Creates a catalog with data, then corrupts file_size_bytes to a negative value |
| 16 | +fn create_catalog_with_negative_file_size( |
| 17 | + catalog_path: &std::path::Path, |
| 18 | +) -> anyhow::Result<()> { |
| 19 | + let conn = duckdb::Connection::open_in_memory()?; |
| 20 | + conn.execute("INSTALL ducklake;", [])?; |
| 21 | + conn.execute("LOAD ducklake;", [])?; |
| 22 | + |
| 23 | + let ducklake_path = format!("ducklake:{}", catalog_path.display()); |
| 24 | + conn.execute( |
| 25 | + &format!("ATTACH '{}' AS test_catalog;", ducklake_path), |
| 26 | + [], |
| 27 | + )?; |
| 28 | + |
| 29 | + conn.execute( |
| 30 | + "CREATE TABLE test_catalog.items (id INT, name VARCHAR);", |
| 31 | + [], |
| 32 | + )?; |
| 33 | + conn.execute( |
| 34 | + "INSERT INTO test_catalog.items VALUES (1, 'Widget'), (2, 'Gadget');", |
| 35 | + [], |
| 36 | + )?; |
| 37 | + |
| 38 | + // Detach the DuckLake catalog so we can tamper with the raw metadata |
| 39 | + conn.execute("DETACH test_catalog;", [])?; |
| 40 | + |
| 41 | + // Now open the catalog DB directly and corrupt file_size_bytes |
| 42 | + let meta_conn = duckdb::Connection::open(catalog_path)?; |
| 43 | + meta_conn.execute( |
| 44 | + "UPDATE ducklake_data_file SET file_size_bytes = -1;", |
| 45 | + [], |
| 46 | + )?; |
| 47 | + |
| 48 | + Ok(()) |
| 49 | +} |
| 50 | + |
| 51 | +/// Creates a catalog with data, then corrupts footer_size to a negative value |
| 52 | +fn create_catalog_with_negative_footer_size( |
| 53 | + catalog_path: &std::path::Path, |
| 54 | +) -> anyhow::Result<()> { |
| 55 | + let conn = duckdb::Connection::open_in_memory()?; |
| 56 | + conn.execute("INSTALL ducklake;", [])?; |
| 57 | + conn.execute("LOAD ducklake;", [])?; |
| 58 | + |
| 59 | + let ducklake_path = format!("ducklake:{}", catalog_path.display()); |
| 60 | + conn.execute( |
| 61 | + &format!("ATTACH '{}' AS test_catalog;", ducklake_path), |
| 62 | + [], |
| 63 | + )?; |
| 64 | + |
| 65 | + conn.execute( |
| 66 | + "CREATE TABLE test_catalog.items (id INT, name VARCHAR);", |
| 67 | + [], |
| 68 | + )?; |
| 69 | + conn.execute( |
| 70 | + "INSERT INTO test_catalog.items VALUES (1, 'Widget'), (2, 'Gadget');", |
| 71 | + [], |
| 72 | + )?; |
| 73 | + |
| 74 | + // Detach the DuckLake catalog so we can tamper with the raw metadata |
| 75 | + conn.execute("DETACH test_catalog;", [])?; |
| 76 | + |
| 77 | + // Now open the catalog DB directly and set footer_size to negative |
| 78 | + let meta_conn = duckdb::Connection::open(catalog_path)?; |
| 79 | + meta_conn.execute( |
| 80 | + "UPDATE ducklake_data_file SET footer_size = -42;", |
| 81 | + [], |
| 82 | + )?; |
| 83 | + |
| 84 | + Ok(()) |
| 85 | +} |
| 86 | + |
| 87 | +fn create_catalog(path: &str) -> DataFusionResult<Arc<DuckLakeCatalog>> { |
| 88 | + let provider = DuckdbMetadataProvider::new(path) |
| 89 | + .map_err(|e| datafusion::error::DataFusionError::External(Box::new(e)))?; |
| 90 | + let catalog = DuckLakeCatalog::new(provider) |
| 91 | + .map_err(|e| datafusion::error::DataFusionError::External(Box::new(e)))?; |
| 92 | + Ok(Arc::new(catalog)) |
| 93 | +} |
| 94 | + |
| 95 | +#[tokio::test] |
| 96 | +async fn test_negative_file_size_produces_clear_error() -> DataFusionResult<()> { |
| 97 | + let temp_dir = |
| 98 | + TempDir::new().map_err(|e| datafusion::error::DataFusionError::External(Box::new(e)))?; |
| 99 | + let catalog_path = temp_dir.path().join("neg_size.ducklake"); |
| 100 | + |
| 101 | + create_catalog_with_negative_file_size(&catalog_path) |
| 102 | + .map_err(|e| datafusion::error::DataFusionError::External(e.into()))?; |
| 103 | + |
| 104 | + let catalog = create_catalog(&catalog_path.to_string_lossy())?; |
| 105 | + let ctx = SessionContext::new(); |
| 106 | + ctx.register_catalog("ducklake", catalog); |
| 107 | + |
| 108 | + let result = ctx |
| 109 | + .sql("SELECT * FROM ducklake.main.items") |
| 110 | + .await? |
| 111 | + .collect() |
| 112 | + .await; |
| 113 | + |
| 114 | + assert!(result.is_err(), "Query should fail with negative file_size_bytes"); |
| 115 | + let err_msg = result.unwrap_err().to_string(); |
| 116 | + assert!( |
| 117 | + err_msg.contains("Invalid file_size_bytes"), |
| 118 | + "Error should mention invalid file_size_bytes, got: {}", |
| 119 | + err_msg |
| 120 | + ); |
| 121 | + assert!( |
| 122 | + err_msg.contains("-1"), |
| 123 | + "Error should contain the negative value, got: {}", |
| 124 | + err_msg |
| 125 | + ); |
| 126 | + |
| 127 | + Ok(()) |
| 128 | +} |
| 129 | + |
| 130 | +#[tokio::test] |
| 131 | +async fn test_negative_footer_size_is_gracefully_skipped() -> DataFusionResult<()> { |
| 132 | + let temp_dir = |
| 133 | + TempDir::new().map_err(|e| datafusion::error::DataFusionError::External(Box::new(e)))?; |
| 134 | + let catalog_path = temp_dir.path().join("neg_footer.ducklake"); |
| 135 | + |
| 136 | + create_catalog_with_negative_footer_size(&catalog_path) |
| 137 | + .map_err(|e| datafusion::error::DataFusionError::External(e.into()))?; |
| 138 | + |
| 139 | + let catalog = create_catalog(&catalog_path.to_string_lossy())?; |
| 140 | + let ctx = SessionContext::new(); |
| 141 | + ctx.register_catalog("ducklake", catalog); |
| 142 | + |
| 143 | + // Negative footer_size should be skipped (not used as hint), query should succeed |
| 144 | + let df = ctx |
| 145 | + .sql("SELECT * FROM ducklake.main.items") |
| 146 | + .await?; |
| 147 | + let batches = df.collect().await?; |
| 148 | + |
| 149 | + let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum(); |
| 150 | + assert_eq!(total_rows, 2, "Should still return all rows when footer_size is negative"); |
| 151 | + |
| 152 | + Ok(()) |
| 153 | +} |
0 commit comments