fix(datetime): tighten gen and whitelist

Author: kumarUjjawal

src/cli/error_whitelist.rs

@@ -103,12 +103,24 @@ static ERROR_PATTERNS: LazyLock<Vec<ErrorPattern>> = LazyLock::new(|| {
             query_sub: "to_date(",
             error_sub: "Casting from",
         },
+        ErrorPattern::QueryAndErrorContains {
+            query_sub: "to_date(",
+            error_sub: "Error parsing timestamp from",
+        },
         ErrorPattern::QueryAndErrorContains {
             query_sub: "to_char(",
             error_sub: "Cannot cast",
         },
         ErrorPattern::Contains("Regular expression did not compile"),
         ErrorPattern::Contains("to_unixtime function unsupported data type"),
+        ErrorPattern::QueryAndErrorContains {
+            query_sub: "to_unixtime(",
+            error_sub: "Error parsing timestamp from",
+        },
+        ErrorPattern::QueryAndErrorContains {
+            query_sub: "to_timestamp",
+            error_sub: "Error parsing timestamp from",
+        },
         // =========================
         // Known Issues
         // =========================
@@ -233,3 +245,32 @@ pub fn get_configured_patterns() -> Vec<String> {
         })
         .collect()
 }
+
+#[cfg(test)]
+mod tests {
+    use super::is_error_whitelisted;
+
+    #[test]
+    fn whitelists_timestamp_parse_errors_for_to_timestamp_queries() {
+        let error = "Query execution failed: Execution error: Error parsing timestamp from 'abc' using format 'fmt': input contains invalid characters";
+        let query = "SELECT to_timestamp_seconds(66, 'fmt')";
+
+        assert!(is_error_whitelisted(error, Some(query)));
+    }
+
+    #[test]
+    fn does_not_whitelist_timestamp_parse_errors_without_to_timestamp_query() {
+        let error = "Query execution failed: Execution error: Error parsing timestamp from 'abc' using format 'fmt': input contains invalid characters";
+        let query = "SELECT 1";
+
+        assert!(!is_error_whitelisted(error, Some(query)));
+    }
+
+    #[test]
+    fn whitelists_timestamp_parse_errors_for_to_date_queries() {
+        let error = "Query execution failed: Execution error: Error parsing timestamp from 'abc' using format 'fmt': input contains invalid characters";
+        let query = "SELECT to_date('abc', 'fmt')";
+
+        assert!(is_error_whitelisted(error, Some(query)));
+    }
+}

src/query_generator/expr_impl.rs

@@ -1092,16 +1092,19 @@ impl BaseExprWithInfo for ToUnixtimeExpr {
         ExprWrapper {
             expr: BaseExpr::ToUnixtime,
             return_type: return_types,
-            inferred_child_signature: vec![vec![
-                TypeGroup::OneOf(vec![
+            inferred_child_signature: vec![
+                vec![TypeGroup::OneOf(vec![
                     FuzzerDataType::String.to_datafusion_type(),
                     FuzzerDataType::Date32.to_datafusion_type(),
                     FuzzerDataType::Timestamp.to_datafusion_type(),
                     FuzzerDataType::Float32.to_datafusion_type(),
                     FuzzerDataType::Float64.to_datafusion_type(),
-                ]),
-                TypeGroup::OneOf(vec![FuzzerDataType::String.to_datafusion_type()]),
-            ]],
+                ])],
+                vec![
+                    TypeGroup::Fixed(FuzzerDataType::String.to_datafusion_type()),
+                    TypeGroup::Fixed(FuzzerDataType::String.to_datafusion_type()),
+                ],
+            ],
         }
     }