Revert "fix(duckdb): use actual DuckDB schema for read provider (#650)"

This reverts commit 040aa83.

Author: ewgenius

core/src/duckdb.rs

@@ -485,7 +485,15 @@ impl TableProviderFactory for DuckDBTableProviderFactory {
                 .with_indexes(indexes.clone());
 
         let pool = Arc::new(pool);
-        make_initial_table(Arc::new(table_definition), &pool)?;
+        make_initial_table(Arc::new(table_definition.clone()), &pool)?;
+
+        let write_settings = DuckDBWriteSettings::from_params(&options);
+
+        let table_writer_builder = DuckDBTableWriterBuilder::new()
+            .with_table_definition(table_definition)
+            .with_pool(pool)
+            .set_on_conflict(on_conflict)
+            .with_write_settings(write_settings);
 
         let dyn_pool: Arc<DynDuckDbConnectionPool> = Arc::new(read_pool);
 
@@ -502,28 +510,9 @@ impl TableProviderFactory for DuckDBTableProviderFactory {
         self.settings_registry
             .apply_settings(conn, &options, DuckDBSettingScope::Global)?;
 
-        // Read actual DuckDB schema after table creation (may differ from cmd.schema).
-        let schema_conn = dyn_pool.connect().await?;
-        let schema = get_schema(schema_conn, &TableReference::bare(name.clone()))
-            .await
-            .map_err(|e| DataFusionError::External(Box::new(e)))?;
-
-        let table_definition =
-            TableDefinition::new(RelationName::new(name.clone()), Arc::clone(&schema))
-                .with_constraints(cmd.constraints.clone())
-                .with_indexes(indexes.clone());
-
-        let write_settings = DuckDBWriteSettings::from_params(&options);
-
-        let table_writer_builder = DuckDBTableWriterBuilder::new()
-            .with_table_definition(table_definition)
-            .with_pool(pool)
-            .set_on_conflict(on_conflict)
-            .with_write_settings(write_settings);
-
         let read_provider = Arc::new(DuckDBTable::new_with_schema(
             &dyn_pool,
-            schema,
+            Arc::clone(&schema),
             TableReference::bare(name.clone()),
             None,
             Some(self.dialect.clone()),
@@ -809,7 +798,7 @@ pub(crate) mod tests {
     use crate::duckdb::write::DuckDBTableWriter;
 
     use super::*;
-    use arrow::datatypes::{DataType, Field, Schema, TimeUnit};
+    use arrow::datatypes::{DataType, Field, Schema};
     use datafusion::common::{Constraints, ToDFSchema};
     use datafusion::logical_expr::CreateExternalTable;
     use datafusion::prelude::SessionContext;
@@ -1128,57 +1117,4 @@ pub(crate) mod tests {
             assert_eq!(e.to_string(), "External error: Query execution failed.\nInvalid Input Error: Failed to cast value: Could not convert string 'invalid' to BOOL\nFor details, refer to the DuckDB manual: https://duckdb.org/docs/");
         }
     }
-
-    /// Verifies the read provider advertises actual DuckDB storage types,
-    /// not the requested cmd.schema types.
-    #[tokio::test]
-    async fn test_read_provider_schema_reflects_actual_duckdb_types() {
-        let table_name = TableReference::bare("test_timestamp_schema");
-        let schema = Schema::new(vec![
-            Field::new("id", DataType::Int32, false),
-            Field::new(
-                "created_at",
-                DataType::Timestamp(TimeUnit::Nanosecond, Some("UTC".into())),
-                false,
-            ),
-        ]);
-
-        let mut options = HashMap::new();
-        options.insert("mode".to_string(), "memory".to_string());
-
-        let factory = DuckDBTableProviderFactory::new(duckdb::AccessMode::ReadWrite);
-        let ctx = SessionContext::new();
-        let cmd = CreateExternalTable {
-            schema: Arc::new(schema.to_dfschema().expect("to df schema")),
-            name: table_name,
-            location: "".to_string(),
-            file_type: "".to_string(),
-            table_partition_cols: vec![],
-            if_not_exists: false,
-            definition: None,
-            order_exprs: vec![],
-            unbounded: false,
-            options,
-            constraints: Constraints::default(),
-            column_defaults: HashMap::new(),
-            temporary: false,
-            or_replace: false,
-        };
-
-        let table_provider = factory
-            .create(&ctx.state(), &cmd)
-            .await
-            .expect("table provider created");
-
-        let read_schema = table_provider.schema();
-        let ts_field = read_schema
-            .field_with_name("created_at")
-            .expect("created_at field exists");
-
-        // DuckDB stores TIMESTAMPTZ as Microsecond regardless of requested precision.
-        match ts_field.data_type() {
-            DataType::Timestamp(TimeUnit::Microsecond, _) => {}
-            other => panic!("Expected Timestamp(Microsecond, _), got {other:?}"),
-        }
-    }
 }