Move methods

Author: trueleo

core/src/sql/sql_provider_datafusion/federation.rs

@@ -13,10 +13,25 @@ use datafusion::{
     arrow::datatypes::SchemaRef,
     error::{DataFusionError, Result as DataFusionResult},
     physical_plan::{stream::RecordBatchStreamAdapter, SendableRecordBatchStream},
-    sql::{unparser::dialect::Dialect, TableReference},
+    sql::{
+        unparser::dialect::{DefaultDialect, Dialect},
+        TableReference,
+    },
 };
 
 impl<T, P> SqlTable<T, P> {
+    // Return the current memory location of the object as a unique identifier
+    fn unique_id(&self) -> usize {
+        std::ptr::from_ref(self) as usize
+    }
+
+    fn arc_dialect(&self) -> Arc<dyn Dialect + Send + Sync> {
+        match &self.dialect {
+            Some(dialect) => Arc::clone(dialect),
+            None => Arc::new(DefaultDialect {}),
+        }
+    }
+
     fn create_federated_table_source(
         self: Arc<Self>,
     ) -> DataFusionResult<Arc<dyn FederatedTableSource>> {

core/src/sql/sql_provider_datafusion/mod.rs

@@ -156,12 +156,6 @@ impl<T, P> SqlTable<T, P> {
         )?))
     }
 
-    #[cfg(feature = "federation")]
-    // Return the current memory location of the object as a unique identifier
-    fn unique_id(&self) -> usize {
-        std::ptr::from_ref(self) as usize
-    }
-
     #[must_use]
     pub fn with_dialect(self, dialect: Arc<dyn Dialect + Send + Sync>) -> Self {
         Self {
@@ -186,14 +180,6 @@ impl<T, P> SqlTable<T, P> {
             None => &DefaultDialect {},
         }
     }
-
-    #[cfg(feature = "federation")]
-    fn arc_dialect(&self) -> Arc<dyn Dialect + Send + Sync> {
-        match &self.dialect {
-            Some(dialect) => Arc::clone(dialect),
-            None => Arc::new(DefaultDialect {}),
-        }
-    }
 }
 
 #[async_trait]