feat: Prefer crs_type: authority_code instead of srid in ST_Point (#37)

* feat: Prefer crs_type: `authority_code` instead of `srid`

* fix python test

Author: kylebarron

python/tests/udf/native/test_constructors.py

@@ -13,6 +13,6 @@ def test_st_point_crs_geoarrow():
     df = ctx.sql(sql)
     schema = Table(df).schema
     assert schema.field("geom").metadata_str == {
-        "ARROW:extension:metadata": '{"crs":"4326","crs_type":"srid"}',
+        "ARROW:extension:metadata": '{"crs":"EPSG:4326","crs_type":"authority_code"}',
         "ARROW:extension:name": "geoarrow.point",
     }

rust/geodatafusion/src/udf/native/constructors/point.rs

@@ -77,7 +77,7 @@ impl ScalarUDFImpl for Point {
 
         if let Some(srid) = args.scalar_arguments.get(2) {
             if let Some(ScalarValue::Int64(srid_val)) = srid {
-                let crs = Crs::from_srid(srid_val.unwrap().to_string());
+                let crs = Crs::from_authority_code(format!("EPSG:{}", srid_val.unwrap()));
                 typ = typ.with_metadata(Arc::new(Metadata::new(crs, None)));
             } else {
                 return Err(DataFusionError::Internal(
@@ -173,7 +173,7 @@ impl ScalarUDFImpl for PointZ {
 
         if let Some(srid) = args.scalar_arguments.get(3) {
             if let Some(ScalarValue::Int64(srid_val)) = srid {
-                let crs = Crs::from_srid(srid_val.unwrap().to_string());
+                let crs = Crs::from_authority_code(format!("EPSG:{}", srid_val.unwrap()));
                 typ = typ.with_metadata(Arc::new(Metadata::new(crs, None)));
             } else {
                 return Err(DataFusionError::Internal(
@@ -270,7 +270,7 @@ impl ScalarUDFImpl for PointM {
 
         if let Some(srid) = args.scalar_arguments.get(3) {
             if let Some(ScalarValue::Int64(srid_val)) = srid {
-                let crs = Crs::from_srid(srid_val.unwrap().to_string());
+                let crs = Crs::from_authority_code(format!("EPSG:{}", srid_val.unwrap()));
                 typ = typ.with_metadata(Arc::new(Metadata::new(crs, None)));
             } else {
                 return Err(DataFusionError::Internal(
@@ -369,7 +369,7 @@ impl ScalarUDFImpl for PointZM {
 
         if let Some(srid) = args.scalar_arguments.get(4) {
             if let Some(ScalarValue::Int64(srid_val)) = srid {
-                let crs = Crs::from_srid(srid_val.unwrap().to_string());
+                let crs = Crs::from_authority_code(format!("EPSG:{}", srid_val.unwrap()));
                 typ = typ.with_metadata(Arc::new(Metadata::new(crs, None)));
             } else {
                 return Err(DataFusionError::Internal(
@@ -776,7 +776,7 @@ mod test {
         let point_type = output_field.extension_type::<PointType>();
         assert_eq!(
             point_type.metadata().crs(),
-            &Crs::from_srid("4326".to_string())
+            &Crs::from_authority_code("EPSG:4326".to_string())
         );
     }
 }

rust/geodatafusion/src/udf/native/io/wkb.rs

@@ -203,7 +203,7 @@ mod test {
     async fn test_as_binary() {
         let ctx = SessionContext::new();
 
-        let crs = Crs::from_srid("4326".to_string());
+        let crs = Crs::from_authority_code("EPSG:4326".to_string());
         let metadata = Arc::new(Metadata::new(crs.clone(), Default::default()));
 
         let point_arr = point::array(CoordType::Separated, Dimension::XY).with_metadata(metadata);

rust/geodatafusion/src/udf/native/io/wkt.rs

@@ -208,7 +208,7 @@ mod test {
     async fn test_as_text() {
         let ctx = SessionContext::new();
 
-        let crs = Crs::from_srid("4326".to_string());
+        let crs = Crs::from_authority_code("EPSG:4326".to_string());
         let metadata = Arc::new(Metadata::new(crs.clone(), Default::default()));
 
         let geo_arr = point::array(CoordType::Separated, Dimension::XY).with_metadata(metadata);