Skip to content

Commit 6e158b2

Browse files
authored
Merge pull request #1502 from theseyi/datahub
Fixes login tests related to token removal
2 parents 81e34e8 + 59ed313 commit 6e158b2

File tree

3 files changed

+3
-94
lines changed

3 files changed

+3
-94
lines changed

datahub-web/packages/data-portal/mirage/helpers/authenticate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const getAuth = (_schema: {}, { requestBody }: { requestBody: string }) => {
1919
return new Response(400, textContentHeader, 'Missing or invalid [credentials]');
2020
}
2121

22-
if (password === 'invalidPassword' || password === 'invalidPassword123456' || password === 'validPasswordWithNoVip') {
22+
if (password === 'invalidPassword' || password === 'invalidPassword123456') {
2323
return new Response(401, textContentHeader, 'Invalid Password');
2424
}
2525

datahub-web/packages/data-portal/tests/acceptance/login-test.js

Lines changed: 0 additions & 89 deletions
This file was deleted.

datahub-web/packages/data-portal/tests/helpers/login/test-login.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
import { visit, click, fillIn } from '@ember/test-helpers';
2-
import { authenticationUrl, testUser, testPassword, testVipToken } from 'wherehows-web/tests/helpers/login/constants';
2+
import { authenticationUrl, testUser, testPassword } from 'wherehows-web/tests/helpers/login/constants';
33
import {
44
loginUserInput,
55
loginPasswordInput,
6-
loginSubmitButton,
7-
loginVipTokenInput
6+
loginSubmitButton
87
} from 'wherehows-web/tests/helpers/login/page-element-constants';
98

109
const appLogin = async (): Promise<void> => {
1110
await visit(authenticationUrl);
1211
await fillIn(loginUserInput, testUser);
1312
await fillIn(loginPasswordInput, testPassword);
14-
await fillIn(loginVipTokenInput, testVipToken.toString());
1513
await click(loginSubmitButton);
1614
};
1715

0 commit comments

Comments
 (0)