Skip to content

Commit 4244679

Browse files
authored
Merge pull request #36 from dataiku/chore/dss13-sc-204977-plugin-gke-add-separator-in-nodepool-parameter
UI improvements in nodepool definitions
2 parents 13c9f48 + c5f2c01 commit 4244679

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

parameter-sets/node-pool-request/parameter-set.json

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,12 @@
1010
"pluginParams": [
1111
],
1212
"params": [
13-
{
13+
{
14+
"type": "SEPARATOR",
15+
"label": "Node pool definition",
16+
"description": "<hr>"
17+
},
18+
{
1419
"name": "machineType",
1520
"label": "Machine type",
1621
"description": "GCE machine type for the nodes. See GCP documentation for available machine types.",
@@ -160,7 +165,6 @@
160165
{
161166
"name": "nodepoolTaints",
162167
"label": "Nodepool taints",
163-
"description": "WARNING: MUST CREATE AT LEAST ONE NODE POOL WITHOUT TAINTS. https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/",
164168
"mandatory": false,
165169
"type": "OBJECT_LIST",
166170
"subParams": [
@@ -194,6 +198,11 @@
194198
}
195199
]
196200
},
201+
{
202+
"type": "SEPARATOR",
203+
"description": "<div class=\"alert alert-warning\"><i class=\"icon-dku-warning\"/><span>WARNING: MUST CREATE AT LEAST ONE NODE POOL WITHOUT TAINTS. <a href=\"https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/\">See documentation</a></span></div>",
204+
"visibilityCondition": "model.nodepoolTaints && (model.nodepoolTaints.length > 0)"
205+
},
197206
{
198207
"name": "nodepoolGCPLabels",
199208
"type": "MAP",

0 commit comments

Comments
 (0)