Chore canon #1
Chore canon #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README documentation to clarify the codec's status, improve terminology consistency, and streamline descriptions. The main changes focus on renaming photon_sensitivity to conversion_gain throughout and adding provenance information.
- Renamed parameter terminology from
photon_sensitivitytoconversion_gainfor consistency - Added status section clarifying this as the official maintained repository
- Simplified and clarified codec description text
- Updated workflow badge reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@dimitri-yatsenko I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: dimitri-yatsenko <[email protected]>
[WIP] Update README documentation for codec clarity
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/test_zarr.py
Outdated
| z_arr_r = open_array(store=store) | ||
| assert z_arr_r.dtype == decoded_dtype | ||
| assert nearly_equal(z_arr_r, data_rt, sensitivity / 2) | ||
| breakpoint() |
d-v-b
left a comment
d-v-b
left a comment
There was a problem hiding this comment.
tests are failing, but the source code is unchanged, so we just need to fix the tests I think
No description provided.