Skip to content

Commit 64684a1

Browse files
author
Thinh Nguyen
authored
Merge pull request #154 from kabilar/main
Update GitHub Actions, Dev Container, and dependencies
2 parents 7217598 + 4b53586 commit 64684a1

File tree

9 files changed

+37
-59
lines changed

9 files changed

+37
-59
lines changed

.devcontainer/Dockerfile

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,11 @@ RUN \
3030
COPY ./ /tmp/element-calcium-imaging/
3131

3232
RUN \
33-
# workflow dependencies
34-
# apt-get install gcc ffmpeg libsm6 libxext6 -y && \
35-
# pip install --no-cache-dir Pygments==2.14.0 && \
36-
# git clone https://github.com/datajoint/CaImAn.git && \
37-
# pip install --no-cache-dir -r ./CaImAn/requirements.txt && \
38-
# pip install --no-cache-dir ./CaImAn && \
39-
pip install git+https://github.com/datajoint/sbxreader && \
40-
pip install git+https://github.com/atlab/scanreader && \
41-
pip install --no-cache-dir -e /tmp/element-calcium-imaging[elements,nd2,suite2p,tests] && \
33+
# pipeline dependencies
34+
apt-get install gcc g++ ffmpeg libsm6 libxext6 -y && \
35+
pip install --no-cache-dir -e /tmp/element-calcium-imaging[caiman_requirements] && \
36+
pip install --no-cache-dir -e /tmp/element-calcium-imaging[caiman,elements,nd2,sbxreader,scanreader,suite2p,tests] && \
4237
# clean up
43-
# rm -rf /tmp/CaImAn && \
4438
rm -rf /tmp/element-calcium-imaging && \
4539
apt-get clean
4640

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"vscode": {
2424
"extensions": [
2525
26-
26+
2727
]
2828
}
2929
}

.devcontainer/docker-compose.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ services:
44
cpus: 4
55
mem_limit: 8g
66
# build:
7-
# context: ../..
7+
# context: ..
88
# dockerfile: ./.devcontainer/Dockerfile
9-
image: datajoint/element_calcium_imaging_devcontainer:latest
9+
image: datajoint/element_calcium_imaging:latest
1010
extra_hosts:
1111
- fakeservices.datajoint.io:127.0.0.1
1212
environment:

.github/workflows/test.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ on:
33
push:
44
pull_request:
55
workflow_dispatch:
6+
schedule:
7+
- cron: "0 8 * * 1"
68
jobs:
79
devcontainer-build:
810
uses: datajoint/.github/.github/workflows/devcontainer-build.yaml@main

CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,14 @@
33
Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and
44
[Keep a Changelog](https://keepachangelog.com/en/1.0.0/) convention.
55

6-
## [0.7.8] - 2023-07-23
6+
## [0.7.9] - 2023-07-27
7+
8+
+ Update - GitHub Actions to run every Monday at 8am
9+
+ Update - Dev Container to install CaImAn and rename Docker image
10+
+ Update - `extras_require` to increment `element-interface` version
11+
+ Update - `extras_require` to include `caiman`, `sbxreader`, and `scanreader`
12+
13+
## [0.7.8] - 2023-07-27
714

815
+ Update - import statement for `prairie_view_loader` in `scan.py`
916

@@ -160,6 +167,7 @@ Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and
160167
+ Add - `scan` and `imaging` modules
161168
+ Add - Readers for `ScanImage`, `ScanBox`, `Suite2p`, `CaImAn`
162169

170+
[0.7.9]: https://github.com/datajoint/element-calcium-imaging/releases/tag/0.7.9
163171
[0.7.8]: https://github.com/datajoint/element-calcium-imaging/releases/tag/0.7.8
164172
[0.7.7]: https://github.com/datajoint/element-calcium-imaging/releases/tag/0.7.7
165173
[0.7.6]: https://github.com/datajoint/element-calcium-imaging/releases/tag/0.7.6

Dockerfile

Lines changed: 0 additions & 15 deletions
This file was deleted.

docker-compose-build.yaml

Lines changed: 0 additions & 26 deletions
This file was deleted.

docs/src/index.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ combined with other Elements to assemble a fully functional pipeline.
2121

2222
![pipeline](https://raw.githubusercontent.com/datajoint/element-calcium-imaging/main/images/pipeline_imaging.svg)
2323

24-
+ We have designed three variations of the pipeline to handle different use cases. Displayed above is the default `imaging` schema. Details on all of the `imaging` schemas can be found in the [Data Pipeline](./pipeline.md) documentation page.
24+
+ We have designed three variations of the pipeline to handle different use cases.
25+
Displayed above is the default `imaging` schema. Details on all of the `imaging`
26+
schemas can be found in the [Data Pipeline](./pipeline.md) documentation page.
2527

2628
## Getting Started
2729

@@ -39,4 +41,5 @@ combined with other Elements to assemble a fully functional pipeline.
3941

4042
## Support
4143

42-
+ If you need help getting started or run into any errors, please contact our team by email at [email protected].
44+
+ If you need help getting started or run into any errors, please contact our team by
45+

setup.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env python
22
from os import path
3-
43
from setuptools import find_packages, setup
4+
import urllib.request
55

66
pkg_name = "element_calcium_imaging"
77
here = path.abspath(path.dirname(__file__))
@@ -12,6 +12,14 @@
1212
with open(path.join(here, pkg_name, "version.py")) as f:
1313
exec(f.read())
1414

15+
with urllib.request.urlopen(
16+
"https://raw.githubusercontent.com/flatironinstitute/CaImAn/master/requirements.txt"
17+
) as f:
18+
caiman_requirements = f.read().decode("UTF-8").split("\n")
19+
20+
caiman_requirements.remove("")
21+
caiman_requirements.append("future")
22+
1523
setup(
1624
name=pkg_name.replace("_", "-"),
1725
version=__version__, # noqa: F821
@@ -32,15 +40,19 @@
3240
"plotly",
3341
],
3442
extras_require={
43+
"caiman_requirements": [caiman_requirements],
44+
"caiman": ["caiman @ git+https://github.com/datajoint/CaImAn"],
3545
"elements": [
3646
"element-animal>=0.1.8",
3747
"element-event>=0.2.3",
38-
"element-interface>=0.5.4",
48+
"element-interface>=0.6.0",
3949
"element-lab>=0.3.0",
4050
"element-session>=0.1.5",
4151
],
4252
"extract": ["matlabengine", "scipy"],
4353
"nd2": ["nd2"],
54+
"sbxreader": ["sbxreader @ git+https://github.com/jcouto/sbxreader"],
55+
"scanreader": ["scanreader @ git+https://github.com/atlab/scanreader"],
4456
"suite2p": ["suite2p[io]>=0.12.1"],
4557
"tests": ["pytest", "pytest-cov", "shutils"],
4658
},

0 commit comments

Comments
 (0)