update to only use QA folder name (and not optionally quality_assurance) as in the latest version of kpms

Author: MilagrosMarin

element_moseq/moseq_report.py

@@ -103,32 +103,17 @@ def make(self, key):
         for rec in recording_names:
             vid = posefile2vid[rec]
 
-            qa_dirs = ["QA", "quality_assurance"]
-            plot_path = None
-
-            for qa_dir in qa_dirs:
-                potential_path = (
-                    kpms_project_output_dir
-                    / qa_dir
-                    / "plots"
-                    / "keypoint_distance_outliers"
-                    / f"{rec}.png"
-                )
-                if potential_path.exists():
-                    plot_path = potential_path
-                    break
-
-            if plot_path is None:
-                checked_paths = [
-                    kpms_project_output_dir
-                    / qa_dir
-                    / "plots"
-                    / "keypoint_distance_outliers"
-                    / f"{rec}.png"
-                    for qa_dir in qa_dirs
-                ]
+            # Look for outlier plot in QA directory
+            plot_path = (
+                kpms_project_output_dir
+                / "QA"
+                / "plots"
+                / "keypoint_distance_outliers"
+                / f"{rec}.png"
+            )
+            if not plot_path.exists():
                 raise FileNotFoundError(
-                    f"Outlier plot not found for {rec}. Checked paths: {[str(p) for p in checked_paths]}"
+                    f"Outlier plot not found for {rec} at {plot_path}"
                 )
 
             self.insert1(

element_moseq/moseq_train.py

@@ -464,32 +464,17 @@ def make_compute(
                     **kpms_config,
                 )
 
-                qa_dirs = ["QA", "quality_assurance"]
-                plot_path = None
-
-                for qa_dir in qa_dirs:
-                    potential_path = (
-                        kpms_project_output_dir
-                        / qa_dir
-                        / "plots"
-                        / "keypoint_distance_outliers"
-                        / f"{recording_name}.png"
-                    )
-                    if potential_path.exists():
-                        plot_path = potential_path
-                        break
-
-                if plot_path is None:
-                    checked_paths = [
-                        kpms_project_output_dir
-                        / qa_dir
-                        / "plots"
-                        / "keypoint_distance_outliers"
-                        / f"{recording_name}.png"
-                        for qa_dir in qa_dirs
-                    ]
+                # Check if outlier plot was created in QA directory
+                plot_path = (
+                    kpms_project_output_dir
+                    / "QA"
+                    / "plots"
+                    / "keypoint_distance_outliers"
+                    / f"{recording_name}.png"
+                )
+                if not plot_path.exists():
                     raise FileNotFoundError(
-                        f"Could not create outlier plot for {recording_name}. Checked paths: {[str(p) for p in checked_paths]}"
+                        f"Could not create outlier plot for {recording_name} at {plot_path}"
                     )
         return (
             cleaned_coordinates,

element_moseq/plotting/viz_utils.py

@@ -65,26 +65,16 @@ def plot_medoid_distance_outliers(
     """
     from keypoint_moseq.util import get_distance_to_medoid, plot_keypoint_traces
 
-    qa_dirs = ["QA", "quality_assurance"]
-    plot_path = None
-
-    for qa_dir in qa_dirs:
-        potential_path = os.path.join(
-            project_dir,
-            qa_dir,
-            "plots",
-            "keypoint_distance_outliers",
-            f"{recording_name}.png",
-        )
-        # Create directory if it doesn't exist
-        os.makedirs(os.path.dirname(potential_path), exist_ok=True)
-        plot_path = potential_path
-        break  # Use first available directory
-
-    if plot_path is None:
-        raise FileNotFoundError(
-            f"Could not determine plot directory for {recording_name}"
-        )
+    # Use QA directory for outlier plots
+    plot_path = os.path.join(
+        project_dir,
+        "QA",
+        "plots",
+        "keypoint_distance_outliers",
+        f"{recording_name}.png",
+    )
+    # Create directory if it doesn't exist
+    os.makedirs(os.path.dirname(plot_path), exist_ok=True)
 
     original_distances = get_distance_to_medoid(
         original_coordinates
@@ -291,8 +281,6 @@ def copy_pdf_to_png(project_dir, model_name):
         project_dir (Path): Project directory path
         model_name (str): Model name directory
 
-    Returns:
-        None: The function raises errors instead of returning boolean values
     """
     from pdf2image import convert_from_path