Skip to content

Commit 3984c59

Browse files
Modify delete to support cascading, update contributor docs, and fix hot-reload on service up.
1 parent 50001a1 commit 3984c59

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

contributing.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@ There is primarily 3 things to consider when looking to contribute.
1414

1515
After considering the above, you may comment on the issue you'd like to help fix and a maintainer will assign it to you.
1616

17-
## What is the proper pull request (PR) etiquette?
17+
## What is the proper etiquette for proposing changes as contribution?
1818

19-
What is generally expected from new pull requests are the following:
19+
What is generally expected from new contributions are the following:
2020

21+
- Any proposed contributor changes should be introduced in the form of a pull request (PR) from their fork.
2122
- Proper branch target specified. The following is generally the available branches that can be targeted:
2223
- `master` or `main`: Represents the single source of truth and the latest in completed development.
2324
- `pre`: Represents the source at the point of the last stable release.
@@ -30,6 +31,8 @@ What is generally expected from new pull requests are the following:
3031
3. No style errors e.g. PEP8, etc.
3132
4. Similar or better code coverage
3233
- Additional documentation to reflect new feature or behavior introduced.
34+
- A contributor should not approve or merge their own PR.
35+
- Reviewer suggestions or feedback should not be directly committed to a branch on contributor's fork. A less intrusive way to collaborate would be for the reviewer to PR to the contributor's fork/branch that is associated with the main PR currently in review.
3336

3437
Maintainers will also ensure that PR's have the appropriate assignment for reviewer, milestone, and project.
3538

dj_gui_api_server/DJConnector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ def delete_tuple(jwt_payload: dict, schema_name: str, table_name: str,
382382
raise InvalidDeleteRequest('Nothing to delete')
383383

384384
# All check pass thus proceed to delete
385-
tuple_to_delete.delete_quick()
385+
tuple_to_delete.delete(safemode=False)
386386

387387
@staticmethod
388388
def get_table_object(schema_virtual_module, table_name: str):

local-docker-compose.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ services:
1616
- FLASK_ENV=development # enables logging to console from Flask
1717
networks:
1818
- dj-gui-api
19-
# volumes: # can enable this for development to bypass build times
20-
# - ./dj_gui_api_server:/opt/conda/lib/python3.8/site-packages/dj_gui_api_server
19+
volumes: # to bypass build times. Should disable for PROD
20+
- ./dj_gui_api_server:/opt/conda/lib/python3.8/site-packages/dj_gui_api_server
2121
ports:
2222
- "5000:5000"
2323
working_dir: /main

0 commit comments

Comments
 (0)