apply suggestions from code review

Author: jverswijver

CHANGELOG.md

@@ -7,7 +7,7 @@ Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and
 ### Added
 
 - Schema templating for insert queries using query params PR #131
-- Add support for OIDC login flow PR #130
+- Add support for OIDC login flow PR #130 (#125)
 
 ## [0.5.0] - 2022-09-21
 

pharus/interface.py

@@ -30,7 +30,6 @@ def _attempt_login(databaseAddress: str, username: str, password: str):
         dj.config["database.host"] = databaseAddress
         dj.config["database.user"] = username
         dj.config["database.password"] = password
-        print(dj.config, flush=True)
         # Attempt to connect return true if successful, false is failed
         dj.conn(reset=True)
 

pharus/server.py

@@ -5,7 +5,6 @@
 from typing import Callable
 from functools import wraps
 from typing import Union
-import traceback
 
 # Crypto libaries
 from cryptography.hazmat.primitives import serialization as crypto_serialization
@@ -84,7 +83,7 @@ def wrapper(**kwargs):
                 )
             return function(connect_creds, **kwargs)
         except Exception as e:
-            return traceback.format_exc(), 401
+            return str(e), 401
 
     wrapper.__name__ = function.__name__
     return wrapper
@@ -248,7 +247,7 @@ def login() -> dict:
             _DJConnector._attempt_login(**connect_creds)
             return dict(jwt=encoded_jwt)
         except Exception as e:
-            return traceback.format_exc(), 500
+            return str(e), 500
 
 
 @app.route(f"{environ.get('PHARUS_PREFIX', '')}/schema", methods=["GET"])

requirements.txt

@@ -6,4 +6,5 @@ datajoint_connection_hub
 pyyaml
 envyaml
 otumat>=0.3.1
-numpy
+numpy
+requests