Skip to content

Allow for healthchecks and depends_on functionality on docker services that are extended #101

@guzman-raphael

Description

@guzman-raphael

Feature Request

Problem

Currently if you attempt use extends on Docker Compose services with a depends_on configuration, it will throw an error.

Requirements

  • Allow healthchecks to facilitate bringing services up in correct order
  • Allow the extension or inheritance of services with such checks

Justification

This provides a healthy system and easy to diagnose the offending service.

Alternative Considerations

  • Docker Compose extends and depends_on in 2.4 version.
  • Multiple Docker Compose files.
  • Docker Compose 3.X with checks specific to the container so they can be brought up in any order

Related Errors

For example:

rguzman@ALPHA:/github/datajoint-labbook$ PY_VER=3.8 IMAGE=djbase DISTRO=alpine PHARUS_VERSION=$(cat pharus/pharus/version.py | tail -1 | awk -F\' '{print $2}') DJLABBOOK_VERSION=$(cat package.json | grep \"version\" | awk -F\" '{print $4}') HOST_UID=$(id -u) docker-compose -f docker-compose-dev.yaml up --build
ERROR: Cannot extend service 'pharus' in /github/datajoint-labbook/pharus/docker-compose-dev.yaml: services with 'depends_on' cannot be extended

Additional Research and Context

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions