Skip to content

Commit e877a0a

Browse files
authored
Merge pull request #13 from MouseLand/main
pull from upstream
2 parents 8811281 + b3a9172 commit e877a0a

File tree

4 files changed

+30
-14
lines changed

4 files changed

+30
-14
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,16 @@ body:
3030
render: python
3131
validations:
3232
required: true
33+
34+
- type: textarea
35+
attributes:
36+
label: "Example input dataset used to reproduce the issue:"
37+
description: >
38+
Please provide a link to a minimal example dataset that can be
39+
used to reproduce the bug. For developers to quickly fix your issue, it's important
40+
that they can reproduce your problem locally.
41+
placeholder: |
42+
<< Dropbox/Google Drive, etc., some link to the dataset >>
3343
3444
- type: textarea
3545
attributes:

.github/workflows/test_and_deploy.yml

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,22 @@ jobs:
6666
# ONLY UNCOMMENT SECTION BELOW FOR DEBUGGING PURPOSES: allows one to ssh into host machine.
6767
# Follow instructions in https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account
6868
# to add your ssh keys.
69-
# - name: Job failed. Activating debugging mode via up-term.
70-
# if: ${{ failure() }}
71-
# uses: lhotari/action-upterm@v1
72-
# with:
73-
# ## limits ssh access and adds the ssh public key for the user which triggered the workflow
74-
# limit-access-to-actor: true
75-
# ## limits ssh access and adds the ssh public keys of the listed GitHub users
76-
# limit-access-to-users: chriski777, carsen-stringera
77-
69+
# - name: Job failed. Activating debugging mode via up-term.
70+
# if: ${{ failure() }}
71+
# # As of Dec. 2024, The following action does NOT work for MACOS (https://github.com/lhotari/action-upterm/issues/24)
72+
# # uses: lhotari/action-upterm@v1
73+
# # with:
74+
# # ## limits ssh access and adds the ssh public key for the user which triggered the workflow
75+
# # limit-access-to-actor: true
76+
# # ## limits ssh access and adds the ssh public keys of the listed GitHub users
77+
# # limit-access-to-users: chriski777 #, carsen-stringera
78+
79+
# # As of Dec. 2024, use the following for debugging the GitHub Action runners for MacOS
80+
# uses: owenthereal/action-upterm@v1
81+
# with:
82+
# limit-access-to-actor: true
83+
# limit-access-to-users: chriski777
84+
7885
- name: Coverage
7986
# Only run coverage once
8087
if: runner.os == 'Linux'

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
[![Python version](https://img.shields.io/pypi/pyversions/suite2p)](https://pypistats.org/packages/suite2p)
1010
[![Licence: GPL v3](https://img.shields.io/github/license/MouseLand/suite2p)](https://github.com/MouseLand/suite2p/blob/main/LICENSE)
1111
[![Contributors](https://img.shields.io/github/contributors-anon/MouseLand/suite2p)](https://github.com/MouseLand/suite2p/graphs/contributors)
12-
[![website](https://img.shields.io/website?url=https%3A%2F%2Fwww.suite2p.org)](https://www.suite2p.org)
1312
[![repo size](https://img.shields.io/github/repo-size/MouseLand/suite2p)](https://github.com/MouseLand/suite2p/)
1413
[![GitHub stars](https://img.shields.io/github/stars/MouseLand/suite2p?style=social)](https://github.com/MouseLand/suite2p/)
1514
[![GitHub forks](https://img.shields.io/github/forks/MouseLand/suite2p?style=social)](https://github.com/MouseLand/suite2p/)
@@ -95,7 +94,7 @@ If you want to download and edit the code, and use that version,
9594
2. Run `conda create --name suite2p python=3.9`
9695
3. To activate this new environment, run `conda activate suite2p` (you will have to activate every time you want to run suite2p)
9796
4. Install the local version of suite2p into this environment in develop mode with the command `pip install -e .[all]`
98-
5. Run tests: `python setup.py test` or `pytest -vs`, this will automatically download the test data into your `suite2p` folder. The test data is split into two parts: test inputs and expected test outputs which will be downloaded in `data/test_inputs` and `data/test_outputs` respectively. The .zip files for these two parts can be downloaded from these links: [test_inputs](https://www.suite2p.org/static/test_data/test_inputs.zip) and [test_outputs](https://www.suite2p.org/static/test_data/test_outputs.zip).
97+
5. Run tests: `python setup.py test` or `pytest -vs`, this will automatically download the test data into your `suite2p` folder. The test data is split into two parts: test inputs and expected test outputs which will be downloaded in `data/test_inputs` and `data/test_outputs` respectively. The .zip files for these two parts can be downloaded from these links: [test_inputs](https://osf.io/download/67f0087b1ec6658af9b25a70/) and [test_outputs](https://osf.io/download/67f007dba7eb86d7808b8832/).
9998

10099
## Examples
101100

@@ -123,7 +122,7 @@ Then:
123122

124123
### Using the GUI
125124

126-
<img src="https://www.suite2p.org/static/images/multiselect.gif" width="800" alt="selecting multiple ROIs in suite2p with Ctrl"/>
125+
<img src="https://github.com/MouseLand/MouseLand.github.io/releases/download/v0.1/multiselect.gif" width="800" alt="selecting multiple ROIs in suite2p with Ctrl"/>
127126

128127

129128
The suite2p output goes to a folder called "suite2p" inside your save_path, which by default is the same as the data_path. If you ran suite2p in the GUI, it loads the results automatically. Otherwise, you can load the results with File -> Load results or by dragging and dropping the stat.npy file into the GUI.

conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def data_dir():
1818
data_path.mkdir(exist_ok=True)
1919
download_cached_inputs(data_path)
2020
cached_outputs = data_path.joinpath('test_outputs')
21-
cached_outputs_url = 'https://www.suite2p.org/static/test_data/test_outputs.zip'
21+
cached_outputs_url = 'https://osf.io/download/67f007dba7eb86d7808b8832/'
2222
if not os.path.exists(cached_outputs):
2323
extract_zip(data_path.joinpath('test_outputs.zip'), cached_outputs_url, data_path)
2424
return data_path
@@ -32,7 +32,7 @@ def test_ops(tmpdir, data_dir):
3232
def download_cached_inputs(data_path):
3333
""" Downloads test_input data if not present on machine. This function was created so it can also be used by scripts/generate_test_data.py."""
3434
cached_inputs = data_path.joinpath('test_inputs')
35-
cached_inputs_url = 'https://www.suite2p.org/static/test_data/test_inputs.zip'
35+
cached_inputs_url = 'https://osf.io/download/67f0087b1ec6658af9b25a70/'
3636
if not os.path.exists(cached_inputs):
3737
extract_zip(data_path.joinpath('test_inputs.zip'), cached_inputs_url, data_path)
3838

0 commit comments

Comments
 (0)