Skip to content

Re-evaluate rows_failed logic on run results page #106

@bkowshik

Description

@bkowshik

Problem

The rows_failed column like we see in the image below has the value of 1.

image

But, when clicked to view the failing rows, we see multiple failing rows.

image

Solution

Currently, rows_failed might be referring to the number of rows with respect to the entity. Ex: The following airport is not unique in public.airport_data database table which is also true.

{
 "uuid": "374fae80-ddd9-348c-996f-208d9aa77a0b",
 "airport": "Kempegowda International Airport Bengaluru",
 "airport_iata": "BLR"
}

But, a more helpful number could be the number of rows in the dataset which are failing. Ex: Out of the 365 rows in the table, all 365 are failing because they all contain the same name in the airport property.

Additional context

For the tests, I prepared the dataset below with the same airport loaded multiple times into the table.

DROP TABLE public.airport_data CASCADE;

CREATE TABLE IF NOT EXISTS public.airport_data(
    uuid UUID PRIMARY KEY,
    airport  VARCHAR(200) NULL,
    airport_iata  VARCHAR(200) NULL
);

INSERT INTO public.airport_data VALUES('374fae80-ddd9-348c-996f-208d9aa77a0b','Kempegowda International Airport Bengaluru','BLR');
INSERT INTO public.airport_data VALUES('fc8b28a0-f131-37c8-87f4-4adef44f2634','Kempegowda International Airport Bengaluru','BLR');
INSERT INTO public.airport_data VALUES('60bd060f-3c7d-3563-adea-77848a6120d7','Kempegowda International Airport Bengaluru','BLR');
-- ...
-- ...
-- For upto 365 times as in the original dataset.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions