Skip to content

fix: handle URLs more gracefully #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle URLs more gracefully #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeca3ee
fix: handle URLs more gracefully
matrss Feb 27, 2025
8027fe3
chore: add myself to .zenodo.json
matrss Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
"name": "Poldrack, Benjamin",
"orcid": "0000-0001-7628-0801"
},
{
"affiliation": "Institute of Climate and Energy Systems - Stratosphere (ICE-4), Forschungszentrum Jülich, Jülich, Germany",
"name": "Riße, Matthias",
"orcid": "0009-0006-6081-9327"
},
{
"affiliation": "Institute of Neuroscience and Medicine, Brain & Behaviour (INM-7), Research Centre Jülich, Jülich, Germany",
"name": "Szczepanik, Michał",
Expand All @@ -57,4 +62,4 @@
"access_right": "open",
"license": "MIT",
"upload_type": "software"
}
}
11 changes: 7 additions & 4 deletions datalad_next/annexremotes/uncurl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,10 +528,13 @@ def _check_retrieve(
handler(url)
# we succeeded, no need to try again
return True
except UrlOperationsResourceUnknown:
# general system access worked, but at the key location is nothing
# to be found
return False
except (UrlOperationsResourceUnknown, ValueError):
# UrlOperationsResourceUnknown: general system access worked, but
# at the key location is nothing to be found
# ValueError: something else went wrong trying to handle the URL
# (e.g. unknown scheme)
# -> try the next URL
pass
except UrlOperationsRemoteError as e:
# return False only if we could be sure that the remote
# system works properly and just the key is not around
Expand Down
Loading