Remove patch to update that is already included in datalad
#786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adswa
force-pushed
the
remove-update-patch
branch
from
a4b4d77 to
2a62537
Compare
The patch to datalad updates '_choose_update_target' has been proposed as a PR in datalad/datalad#7522 and was merged Oct. 30th 2023. As the code is part of datalad already, I see no reason that this patch needs to be applied or stay in the code base
adswa
force-pushed
the
remove-update-patch
branch
from
2a62537 to
373b11b
Compare
mslw
approved these changes
Jul 23, 2025
Collaborator
mslw
left a comment
mslw
left a comment
There was a problem hiding this comment.
I think you are right. That PR in datalad was merged and the function in datalad is identical to the one in this patch (except for the comment saying "THIS IS THE PATCH").
Member
Author
|
Thanks for the review! FWIW I can't merge because "Merging is blocked Waiting on code owner review from mih." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #785, I found a patch that I deem superfluous.
The patch to datalad updates '_choose_update_target' has been proposed as a PR in datalad/datalad#7522 and was merged Oct. 30th 2023.
As the code is part of datalad already, I see no reason that this patch needs to be applied or stay in the code base