Optimised mypy setup & github actions to use pre-commit (#2)

* Added mypy to pyproject.toml & changed pre-commit to use rye mypy

* switch to pre-commit to run basic CI on GH actions

* added rye run for pre-commit

* added more explicit naming in gh actions

* made name of flow more explicit

* added tests to mypy checks

* Changed pre-commit mypy run to run seperately on tests and src to accomodate missing imports in tests

Author: tleers

.github/workflows/python-basic-ci.yaml

@@ -1,4 +1,4 @@
-name: Basic CI
+name: Basic CI (mirror of local pre-commit CI)
 
 on: [push, pull_request]
 
@@ -14,17 +14,9 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
           architecture: 'x64' # GH does not support arm64, i.e. modern Mac, only x64
-      - name: Setup rye
+      - name: Setup rye on runner
         uses: eifinger/setup-rye@v2
-      - name: Install original package
+      - name: Install rye dependencies
         run: rye sync
-      - name: Run the formatter
-        run: rye fmt -- --diff
-      - name: Run the linter
-        run: rye lint --fix
-      - name: Run the tests
-        run: rye test
-      - name: mypy
-        uses: jpetrucciani/mypy-check@master
-        with:
-          path: 'src'
+      - name: Run precommit CI hooks
+        run: rye run pre-commit run --all-files

.pre-commit-config.yaml

@@ -33,8 +33,15 @@ repos:
       require_serial: true
       additional_dependencies: []
       minimum_pre_commit_version: "2.9.2"
--   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: 'v1.10.1'
+-   repo: local
     hooks:
-      - id: mypy
-        files: src
+      - id: mypy-src
+        name: mypy-src
+        language: system
+        entry: rye run mypy 
+        files: src
+      - id: mypy-tests
+        name: mypy-tests
+        language: system
+        entry: rye run mypy --ignore-missing-imports
+        files: tests 

pyproject.toml

@@ -20,6 +20,7 @@ dev-dependencies = [
     "pre-commit>=3.7.1",
     "ruff>=0.5.0",
     "pytest>=8.2.2",
+    "mypy>=1.10.1",
 ]
 
 [tool.hatch.metadata]

requirements-dev.lock

@@ -19,6 +19,9 @@ identify==2.5.36
     # via pre-commit
 iniconfig==2.0.0
     # via pytest
+mypy==1.10.1
+mypy-extensions==1.0.0
+    # via mypy
 nodeenv==1.9.1
     # via pre-commit
 packaging==24.1
@@ -32,5 +35,7 @@ pytest==8.2.2
 pyyaml==6.0.1
     # via pre-commit
 ruff==0.5.0
+typing-extensions==4.12.2
+    # via mypy
 virtualenv==20.26.3
     # via pre-commit