Skip to content

Move device model mapping to backend #72

Open
@Roconda

Description

Problem

Currently the mapping of device's model name is done within this SDK. The device's technical name will be converted to a marketing name.

Since the mapping is done in the frontend the list can be outdated and unable to map device names. The Android implementation does sync a list from an upstream party, the iOS' doesn't. The list can get outdated and adds another dependency within this SDK, thus more maintenance for parties who will implement this SDK.

Android

https://github.com/O2MC/dimml-mobile-sdk/blob/ee0fce2f220fae1269bc133b4c5a0206067a290f/android/sdk/src/main/java/io/o2mc/sdk/business/DeviceManager.java#L44

iOS

https://github.com/O2MC/dimml-mobile-sdk/blob/ee0fce2f220fae1269bc133b4c5a0206067a290f/ios/sdk/O2MC/O2MDevice.m#L20-L61

Solution

Move mapping to the backend.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

androidAndroid specificbackendRelated to the backendenhancementNew feature or requestiosiOS specific

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions