Conversation
* 合并 (#8) * chore: add comprehensive contributing guide (#10) * chore: add comprehensive contributing guide * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * ci: restore pr-check.yml workflow for dev branch - Restore backend and frontend PR checks - Enable Python syntax check and import test for backend - Enable pnpm build check for frontend - Fix 'Expected — Waiting for status to be reported' issue * feat(ci): upgrade PR review + add CI auto-fix & review responder - Upgrade codex-pr-review.md to 6-perspective review with confidence scoring - Rewrite claude-pr-review.yml with Codex-first fallback pattern - Add claude-ci-autofix.yml for auto-fixing CI failures + dev sync - Add claude-review-responder.yml for auto-responding to PR reviews - Update CI_CD_SETUP.md with new workflow documentation * fix(ci): address Codex review security findings - [Critical] auto-fix: restrict to same-repo PRs only (fork protection) - [High] review-responder: require explicit @claude mention, restrict to same-repo - [Medium] auto-fix: use `gh run view --log-failed` instead of broken API call - [Medium] pr-review: fix Codex matching to use head_sha + pull_requests - [Low] auto-fix: correct workflow name "Tests" → "Test Suite" * fix(ci): restore workflow name to match branch protection rules Rename "Claude PR Review (Fallback)" back to "Claude PR Review" so the check name matches what branch protection expects. * revert: restore workflow name to "Claude PR Review (Fallback)" * ci: fix invalid workflow syntax * ci: fix pnpm cache setup * ci: fix test workflow step order * ci: harden Claude workflows * ci: pin review responder checkout to SHA --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* 合并 (#8) * chore: add comprehensive contributing guide (#10) * chore: add comprehensive contributing guide * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * ci: restore pr-check.yml workflow for dev branch - Restore backend and frontend PR checks - Enable Python syntax check and import test for backend - Enable pnpm build check for frontend - Fix 'Expected — Waiting for status to be reported' issue * feat(ci): upgrade PR review + add CI auto-fix & review responder - Upgrade codex-pr-review.md to 6-perspective review with confidence scoring - Rewrite claude-pr-review.yml with Codex-first fallback pattern - Add claude-ci-autofix.yml for auto-fixing CI failures + dev sync - Add claude-review-responder.yml for auto-responding to PR reviews - Update CI_CD_SETUP.md with new workflow documentation * fix(ci): address Codex review security findings - [Critical] auto-fix: restrict to same-repo PRs only (fork protection) - [High] review-responder: require explicit @claude mention, restrict to same-repo - [Medium] auto-fix: use `gh run view --log-failed` instead of broken API call - [Medium] pr-review: fix Codex matching to use head_sha + pull_requests - [Low] auto-fix: correct workflow name "Tests" → "Test Suite" * fix(ci): restore workflow name to match branch protection rules Rename "Claude PR Review (Fallback)" back to "Claude PR Review" so the check name matches what branch protection expects. * revert: restore workflow name to "Claude PR Review (Fallback)" * ci: fix invalid workflow syntax * ci: fix pnpm cache setup * ci: fix test workflow step order * ci: harden Claude workflows * ci: pin review responder checkout to SHA * docs: add CONTRIBUTING.md reference in README Direct contributors to read the contributing guide before starting. --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* 合并 (#8) * chore: add comprehensive contributing guide (#10) * chore: add comprehensive contributing guide * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * ci: restore pr-check.yml workflow for dev branch - Restore backend and frontend PR checks - Enable Python syntax check and import test for backend - Enable pnpm build check for frontend - Fix 'Expected — Waiting for status to be reported' issue * feat(ci): upgrade PR review + add CI auto-fix & review responder - Upgrade codex-pr-review.md to 6-perspective review with confidence scoring - Rewrite claude-pr-review.yml with Codex-first fallback pattern - Add claude-ci-autofix.yml for auto-fixing CI failures + dev sync - Add claude-review-responder.yml for auto-responding to PR reviews - Update CI_CD_SETUP.md with new workflow documentation * fix(ci): address Codex review security findings - [Critical] auto-fix: restrict to same-repo PRs only (fork protection) - [High] review-responder: require explicit @claude mention, restrict to same-repo - [Medium] auto-fix: use `gh run view --log-failed` instead of broken API call - [Medium] pr-review: fix Codex matching to use head_sha + pull_requests - [Low] auto-fix: correct workflow name "Tests" → "Test Suite" * fix(ci): restore workflow name to match branch protection rules Rename "Claude PR Review (Fallback)" back to "Claude PR Review" so the check name matches what branch protection expects. * revert: restore workflow name to "Claude PR Review (Fallback)" * ci: fix invalid workflow syntax * ci: fix pnpm cache setup * ci: fix test workflow step order * ci: harden Claude workflows * ci: pin review responder checkout to SHA * docs: add CONTRIBUTING.md reference in README Direct contributors to read the contributing guide before starting. * update --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
update test
fix: use env vars instead of secrets in step-level if conditions
Review Summary by QodoRemove .github directory and CI/CD automation files from cankao
WalkthroughsDescription• Removes entire .github directory and its contents from the cankao subdirectory • Deletes CI/CD workflow files including GitHub Actions configurations for PR reviews, issue triage, and automated responses • Removes prompt templates used by Claude-based automation workflows • Deletes configuration files for release management, changelog generation, and CI/CD setup documentation • Eliminates funding and trigger configuration files Diagramflowchart LR
A["cankao/.github<br/>directory"] -- "deleted" --> B["Workflows removed"]
A -- "deleted" --> C["Prompts removed"]
A -- "deleted" --> D["Config files removed"]
B -- "includes" --> E["PR review & CI workflows"]
C -- "includes" --> F["Claude automation prompts"]
D -- "includes" --> G["FUNDING, CI_CD_SETUP, etc."]
File Changes |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
Greptile OverviewGreptile SummaryRemoved the Key changes:
Impact:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .gitignore | Added /cankao/ to gitignore to exclude reference materials directory |
| cankao/.github/CI_CD_SETUP.md | Deleted CI/CD setup documentation (reference material) |
| cankao/.github/workflows/claude-pr-review.yml | Deleted reference workflow file (actual workflow exists in main .github/) |
| cankao/.github/workflows/codex-pr-review.yml | Deleted reference workflow file (actual workflow exists in main .github/) |
| cankao/.github/workflows/release.yml | Deleted reference release workflow (actual workflow exists in main .github/) |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Git as Git Repository
participant GI as .gitignore
Dev->>Git: Remove cankao/ directory (29 files)
Note over Git: Delete reference documentation<br/>workflows, and prompts
Dev->>GI: Add /cankao/ to .gitignore
Note over GI: Prevent future tracking of<br/>cankao/ directory
Git->>Git: Active workflows in .github/<br/>remain unchanged
Note over Git: No impact on CI/CD operations
|
Size calculation from local diff: XL ( # Apply size label (will work in an environment with GitHub API access)
REPO="${PR_REPO:-$GITHUB_REPOSITORY}"
PR="${PR_NUMBER}"
gh pr edit "$PR" --repo "$REPO" --add-label "size/XL"No inline comments: the only added/modified code is a single # Submit review summary (will work in an environment with GitHub API access)
REPO="${PR_REPO:-$GITHUB_REPOSITORY}"
PR="${PR_NUMBER}"
gh pr review "$PR" --repo "$REPO" --comment -F - <<'EOF'
## 🤖 Codex PR Review
This PR is XL primarily due to bulk deletions under `cankao/.github/**` and a one-line `.gitignore` update to ignore `/cankao/`. No backend/frontend runtime source changes are included in the diff; risk is concentrated in removal of reference materials.
### PR Size: XL
- **Lines changed**: 6672
- **Files changed**: 30
- **Split suggestion**: (1) `.gitignore` update to ignore `/cankao/` (2) bulk removal of `cankao/.github/**` reference files.
### Issues Found
| Category | Critical | High | Medium | Low |
|----------|----------|------|--------|-----|
| Logic/Bugs | 0 | 0 | 0 | 0 |
| Security | 0 | 0 | 0 | 0 |
| Error Handling | 0 | 0 | 0 | 0 |
| Types | 0 | 0 | 0 | 0 |
| Comments/Docs | 0 | 0 | 0 | 0 |
| Tests | 0 | 0 | 0 | 0 |
| Simplification | 0 | 0 | 0 | 0 |
### Critical Issues (Must Fix)
None.
### High Priority Issues (Should Fix)
None.
### Review Coverage
- [x] Logic and correctness
- [x] Security (OWASP Top 10)
- [x] Error handling
- [x] Type safety
- [x] Documentation accuracy
- [x] Test coverage
- [x] Code clarity
---
*Automated review by Codex AI*
EOF |
Merge pull request #30 from datawhalechina/main
概要
删除仓库中的
cankao/参考资料目录,并将该目录加入.gitignore防止再次被跟踪。此 PR 将清理同步至 admin 分支。问题
cankao/目录包含大量 GitHub Actions 工作流模板、CI/CD 配置说明文档、Prompt 模板等参考资料文件。这些文件不属于项目运行所需的代码,不应纳入版本控制,占用仓库空间且可能造成混淆。关联 PR:
解决方案
cankao/目录下全部 29 个文件.gitignore中添加/cankao/规则,防止该目录被再次跟踪变更内容
核心变更
cankao/.github/下的全部参考文件,包括:CI_CD_SETUP.md、CI_TRIGGER.md、FUNDING.yml)cliff.toml)changelog-update.md、codex-issue-auto-response.md、codex-pr-review.md、docs-update.md、pr-review-comprehensive.md、release-analysis.md、release-notes.md)claude-ci-autofix.yml、claude-issue-*.yml、claude-mention-responder.yml、claude-pr-*.yml、claude-review-responder.yml、claude-unified-docs.yml、codex-*.yml、dev.yml、pr-check.yml、release.yml、test.yml)辅助变更
.gitignore:新增/cankao/忽略规则(+1 行)测试
自测方式
.github/workflows/.gitignore规则正确Checklist
由 Claude AI 自动生成