chore: remove temporal address from constant (#246)

* chore: remove temporalAddr constant and make retry simple

* chore: remove logs

Author: vishalm0509

server/internal/constants/constants.go

@@ -23,7 +23,6 @@ var (
 	DefaultConfigDir          = "/tmp/olake-config"
 	DefaultLogRetentionPeriod = 30
 	DefaultSpecVersion        = "v0.2.0"
-	DefaultTemporalAddress    = "localhost:7233"
 	// logging
 	EnvLogLevel          = "LOG_LEVEL"
 	EnvLogFormat         = "LOG_FORMAT"

server/internal/services/temporal/client.go

@@ -21,10 +21,13 @@ type Temporal struct {
 
 // NewClient creates a new Temporal client
 func NewClient() (*Temporal, error) {
-	temporalAddress := web.AppConfig.DefaultString(constants.ConfTemporalAddress, constants.DefaultTemporalAddress)
+	temporalAddress, err := web.AppConfig.String(constants.ConfTemporalAddress)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get temporal address: %s", err)
+	}
 
 	var temporalClient *Temporal
-	err := utils.RetryWithBackoff(func() error {
+	err = utils.RetryWithBackoff(func() error {
 		client, dialErr := client.Dial(client.Options{
 			HostPort: temporalAddress,
 		})

server/utils/utils.go

@@ -295,19 +295,22 @@ func ReadLogs(mainLogDir string) ([]map[string]interface{}, error) {
 
 // RetryWithBackoff retries a function with exponential backoff
 func RetryWithBackoff(fn func() error, maxRetries int, initialDelay time.Duration) error {
+	delay := initialDelay
 	var errMsg error
-	for i := 0; i < maxRetries; i++ {
+
+	for retry := 0; retry < maxRetries; retry++ {
 		if err := fn(); err != nil {
 			errMsg = err
-			if i < maxRetries-1 {
-				delay := initialDelay * time.Duration(1<<uint(i)) // exponential: 1s, 2s, 4s, 8s...
-				logger.Warnf("Retry attempt %d/%d failed: %s. Retrying in %v...", i+1, maxRetries, err, delay)
+			if retry < maxRetries-1 {
+				logger.Warnf("Retry attempt %d/%d failed: %s. Retrying in %v...", retry+1, maxRetries, err, delay)
 				time.Sleep(delay)
+				delay *= 2
 				continue
 			}
 		} else {
 			return nil
 		}
 	}
+
 	return fmt.Errorf("failed after %d retries: %s", maxRetries, errMsg)
 }