chore: resolved-comments-1

Author: saksham-datazip

constants/state_version.go

@@ -38,7 +38,7 @@ package constants
 //     * Now these byte slices are parsed and converted into int64
 //
 //   - Version 7: (Current Version) Fixed issues in Reformat.go: ReformatBool and ReformatValue
-//     * Fixed boolean conversion for numeric inputs (int, int8, int16, int32, int64) in ReformatBool
+//     * Fixed boolean conversion for numeric inputs (int8, int16, int32, int64) in ReformatBool
 //     * Fixed float32 and float64 string conversion ("%d" → "%v") in ReformatValue
 
 const (

utils/typeutils/reformat.go

@@ -17,10 +17,6 @@ import (
 	"go.mongodb.org/mongo-driver/bson/primitive"
 )
 
-type StringInterface interface {
-	String() string
-}
-
 var (
 	ErrNullValue = fmt.Errorf("null value")
 )
@@ -44,16 +40,6 @@ var DateTimeFormats = []string{
 
 var GeospatialTypes = []string{"geometry", "point", "polygon", "linestring", "multi"}
 
-func getFirstNotNullType(datatypes []types.DataType) types.DataType {
-	for _, datatype := range datatypes {
-		if datatype != types.Null {
-			return datatype
-		}
-	}
-
-	return types.Null
-}
-
 func ReformatRecord(fields Fields, record types.Record) error {
 	for key, val := range record {
 		field, found := fields[key]
@@ -70,10 +56,6 @@ func ReformatRecord(fields Fields, record types.Record) error {
 	return nil
 }
 
-func ReformatValueOnDataTypes(datatypes []types.DataType, v any) (any, error) {
-	return ReformatValue(getFirstNotNullType(datatypes), v)
-}
-
 func ReformatValue(dataType types.DataType, v any) (any, error) {
 	if v == nil {
 		return v, nil
@@ -96,7 +78,7 @@ func ReformatValue(dataType types.DataType, v any) (any, error) {
 		case uint, uint8, uint16, uint32, uint64:
 			return fmt.Sprintf("%d", v), nil
 		case float32, float64:
-			// Fixed float string conversion (%v) for v>6; older versions retain %d for backward compatibility
+			// Fixed float string conversion (%v) for version > 6; older versions retain %d for backward compatibility
 			if constants.LoadedStateVersion > 6 {
 				return fmt.Sprintf("%v", v), nil
 			}
@@ -149,7 +131,7 @@ func ReformatBool(v interface{}) (bool, error) {
 			return false, nil
 		}
 	case int, int16, int32, int64, int8:
-		// Fixed int8/int16/int32/int64 bool handling for v>6; older versions keep strict comparison
+		// Fixed int8/int16/int32/int64 bool handling for version>6; older versions keep strict comparison
 		if constants.LoadedStateVersion > 6 {
 			switch reflect.ValueOf(booleanValue).Int() {
 			case 1:
@@ -159,15 +141,14 @@ func ReformatBool(v interface{}) (bool, error) {
 			default:
 				return false, fmt.Errorf("found to be boolean, but value is not boolean : %v", v)
 			}
-		} else {
-			switch booleanValue {
-			case 1:
-				return true, nil
-			case 0:
-				return false, nil
-			default:
-				return false, fmt.Errorf("found to be boolean, but value is not boolean : %v", v)
-			}
+		}
+		switch booleanValue {
+		case 1:
+			return true, nil
+		case 0:
+			return false, nil
+		default:
+			return false, fmt.Errorf("found to be boolean, but value is not boolean : %v", v)
 		}
 	default:
 		return false, fmt.Errorf("found to be boolean, but value is not boolean : %v", v)
@@ -543,39 +524,6 @@ func ReformatFloat32(v interface{}) (float32, error) {
 	return float32(0), fmt.Errorf("failed to change %v (type:%T) to float32", v, v)
 }
 
-func ReformatByteArraysToString(data map[string]any) map[string]any {
-	for key, value := range data {
-		switch value := value.(type) {
-		case map[string]any:
-			data[key] = ReformatByteArraysToString(value)
-		case []byte:
-			data[key] = string(value)
-		case []map[string]any:
-			decryptedArray := []map[string]any{}
-			for _, element := range value {
-				decryptedArray = append(decryptedArray, ReformatByteArraysToString(element))
-			}
-
-			data[key] = decryptedArray
-		case []any:
-			decryptedArray := []any{}
-			for _, element := range value {
-				switch element := element.(type) {
-				case map[string]any:
-					decryptedArray = append(decryptedArray, ReformatByteArraysToString(element))
-				case []byte:
-					decryptedArray = append(decryptedArray, string(element))
-				default:
-					decryptedArray = append(decryptedArray, element)
-				}
-			}
-
-			data[key] = decryptedArray
-		}
-	}
-	return data
-}
-
 func ReformatGeoType(v any) (any, error) {
 	if v == nil {
 		return nil, ErrNullValue