Commit a9062fa
feat(stats): widen BLAKE3 fingerprint to cover all streaming stats (#3824)
* feat(stats): widen BLAKE3 fingerprint to cover all streaming stats
Bump `FINGERPRINT_HASH_COLUMNS` from 26 to 29 so the dataset fingerprint
hash now incorporates `n_positive`, `max_precision`, and `sparsity` —
i.e. every streaming column emitted by `stats_headers()`. Previously the
last three streaming columns were silently excluded, leaving
fingerprints that could collide on datasets that differ only in those
fields.
Also rewrite the constant's comment to enumerate the streaming columns
and note the invariant: when a streaming column is added or removed
in `stats_headers()`, the constant must be updated. STATS_DEFINITIONS.md
updated to match.
Existing stats caches built with prior qsv versions will produce a
different `blake3` value after this change; that's harmless because the
cache invalidates on `qsv_version` mismatch already.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>1 parent f3e3ee2 commit a9062fa
2 files changed
Lines changed: 12 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
256 | | - | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
678 | 678 | | |
679 | 679 | | |
680 | 680 | | |
681 | | - | |
682 | | - | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
683 | 692 | | |
684 | 693 | | |
685 | 694 | | |
| |||
0 commit comments