fix: refine profile field population for ZITADEL validation by ensuring fallback values for givenName and familyName are correctly applied

Author: JoseSzycho

apps/login/src/app/(main)/(boxed)/idp/[provider]/success/page.tsx

@@ -101,29 +101,30 @@ export default async function Page(props: {
   const { idpInformation, userId } = intent;
   let { addHumanUser } = intent;
 
-  // ensure mandatory profile fields are populated to satisfy ZITADEL validation (e.g., GitHub may not provide givenName)
+  // ensure mandatory profile fields are populated to satisfy ZITADEL validation, as GitHub does not provide givenName
+  // and familyName
   if (addHumanUser) {
-    const givenNameMissing =
-      !addHumanUser.profile?.givenName ||
-      addHumanUser.profile.givenName.length === 0;
-    const familyNameMissing =
-      !addHumanUser.profile?.familyName ||
-      addHumanUser.profile.familyName.length === 0;
-
-    if (givenNameMissing || familyNameMissing) {
-      addHumanUser = {
-        ...addHumanUser,
-        profile: {
-          ...addHumanUser.profile,
-          givenName: givenNameMissing
-            ? (idpInformation?.userName ?? "user")
-            : addHumanUser.profile?.givenName,
-          familyName: familyNameMissing
-            ? (idpInformation?.userName ?? "user")
-            : addHumanUser.profile?.familyName,
-        },
-      } as typeof addHumanUser;
+    const profile: any = addHumanUser.profile ?? {};
+    let { givenName, familyName } = profile;
+
+    const fallback = idpInformation?.userName ?? "user";
+
+    if (!givenName || givenName.trim().length === 0) {
+      givenName = fallback.slice(0, 200);
     }
+
+    if (!familyName || familyName.trim().length === 0) {
+      familyName = fallback.slice(0, 200);
+    }
+
+    addHumanUser = {
+      ...addHumanUser,
+      profile: {
+        ...profile,
+        givenName,
+        familyName,
+      },
+    } as typeof addHumanUser;
   }
 
   if (!idpInformation) {