icon-current-entry widget doesn't fetch icons at its specified size

[ASong5]

Description

The icon-current-entry widget reuses the icon already loaded by element-icon instead of fetching its own icon at the size specified in the theme. This causes blurry upscaling when trying to show a large preview of a small thumbnail.

Expected Behavior

When using the thumbnail:// prefix with different size properties for element-icon and icon-current-entry, each widget should independently query the icon fetcher at its own requested size:

element-icon {
    size: 32px;  /* Should query thumbnail at 32px */
}

icon-current-entry {
    size: 512px;  /* Should query thumbnail at 512px */
}

This would leverage rofi's thumbnail system to generate and cache multiple sizes (normal/128px, large/256px, x-large/512px, xx-large/1024px) of the same source image.

Actual Behavior

icon-current-entry displays the icon that was already loaded for element-icon, resulting in only one icon query per entry at the element-icon size. When icon-current-entry displays this icon at a larger size, it upscales the already-loaded smaller icon, causing visible blur/pixelation.

Debug Output

Running with G_MESSAGES_DEBUG=Helpers.IconFetcher shows only queries at the element-icon size (32px):

(process:1447713): Helpers.IconFetcher-DEBUG: 16:27:31.906: Query: thumbnail:///tmp/cliphist/245.png(32)
(process:1447713): Helpers.IconFetcher-DEBUG: 16:27:31.908: Query: thumbnail:///tmp/cliphist/221.png(32)
(process:1447713): Helpers.IconFetcher-DEBUG: 16:27:31.909: Query: thumbnail:///tmp/cliphist/211.png(32)

No 512px queries are made when icon-current-entry is displayed, even though it has size: 512px in the theme.

I'm not sure if this is intended behavior or a bug/limitation, and I'm also not sure if this is a case of user error or not (quite possible, only looked into this for a day while trying to get cliphist to integrate with rofi).

I am posting this as a discussion thread rather than an issue in case someone can provide some insight on this, lest I waste the time of the devs/contributors.

Thanks in advance.

[DaveDavenport]

Can you try the 'redraw-fixes' branch? It reworks a lot of these issues.

[ASong5]

It didn't seem to fix this specific issue, although I had to test on an older commit due to build errors.

[DaveDavenport]

That is odd, as it moves the logic of fetching into the widget.. The previous issue should not be possible.
My own test also showed it working fine.

What compile error do you get?

[DaveDavenport]

That commit id, is also on the next branch, not 'redraw-fixes'.

[DaveDavenport]

I fixed a compile issue with xcb disabled on that branch, hopefully that fixes it.

[ASong5]

Thank you so much. That fixed it. Each widget properly requests its own size now. I was trying so hard to get this work for the better part of yesterday to no avail. You're the best!

Edit: This also fixed another issue I was having where the icons for the first/selected entry was not rendering. Sweet!

[DaveDavenport]

yeah, it should fix tons of issues with icons. It needs a lot of testing though, as a lot of the code around drawing has been rewritten.