Merge pull request dnnsoftware#6825 from bdukes/throw-on-invalid-business-controller-type

valadas · web-flow · commit 28c21d6977d9 · 2025-12-02T21:58:51.000-05:00
Throw when null business controller type is attempted to be created
diff --git a/DNN Platform/Library/Entities/Modules/BusinessControllerProvider.cs b/DNN Platform/Library/Entities/Modules/BusinessControllerProvider.cs
@@ -6,6 +6,7 @@ namespace DotNetNuke.Entities.Modules;
 using System;
 
 using DotNetNuke.Abstractions.Modules;
+using DotNetNuke.Common;
 using DotNetNuke.Framework;
 
 /// <summary>The <see cref="IBusinessControllerProvider"/> implementation.</summary>
@@ -36,6 +37,7 @@ public T GetInstance<T>(string businessControllerTypeName)
     public T GetInstance<T>(Type businessControllerType)
         where T : class
     {
+        Requires.NotNull(nameof(businessControllerType), businessControllerType);
         if (typeof(T).IsAssignableFrom(businessControllerType))
         {
             return (T)this.GetInstance(businessControllerType);

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ namespace DotNetNuke.Entities.Modules;`
`6`	`6`	`using System;`
`7`	`7`
`8`	`8`	`using DotNetNuke.Abstractions.Modules;`
	`9`	`+using DotNetNuke.Common;`
`9`	`10`	`using DotNetNuke.Framework;`
`10`	`11`
`11`	`12`	`/// <summary>The <see cref="IBusinessControllerProvider"/> implementation.</summary>`
`@@ -36,6 +37,7 @@ public T GetInstance<T>(string businessControllerTypeName)`
`36`	`37`	`public T GetInstance<T>(Type businessControllerType)`
`37`	`38`	`where T : class`
`38`	`39`	`{`
	`40`	`+ Requires.NotNull(nameof(businessControllerType), businessControllerType);`
`39`	`41`	`if (typeof(T).IsAssignableFrom(businessControllerType))`
`40`	`42`	`{`
`41`	`43`	`return (T)this.GetInstance(businessControllerType);`