Manipulating classpath items should preserve item order

[jeantil]

ScalaCompileMojo#getClasspathElements and ScalaTestCompileMojo#getClasspathElements compute the compilation and test compilation classpath from MavenProject#getCompileClasspathElements which is a List<String>.

Transforming from the ordered List<String> into an unordered Hashset<File> can change the order of classpath elements.

In my specific case, it broke the develocity cache key computation I'm using to improve Apache James build times.
In other cases it could lead to incorrect compilation or compilation errors ..

[slandelle]

Hey buddy !
Glad to see you here!
I’m on vacation, I’ll try to get a look next week but it might have to wait until the week after.

[jeantil]

hello stephane ! I'm on vacation too !

There is no hurry I will have to wait for a release before I put this in james build anyway :D

enjoy your rest :D

[slandelle]

Using a TreeSet feels very weird to me. TreeSet sorts by default with natural order, which I’m not even sure what it means for Files. It doesn’t conserve first insertion order.
What you want is a LinkedHashSet.
Lack of unit tests.

[jeantil]

Sorry about that you are perfectly right. I changed the implementation to use a LinkedHashSet not much available on jdk8. I added a test which is red with both toSet and TreeSet

[slandelle]

Hey @jeantil

4.9.6 is out with your fix. Sorry for the delay.

[jeantil]

Thank you for letting me know ! the delay is perfectly normal :D