fix: don't log a warning if span is disabled#338
Closed
flokli wants to merge 2 commits into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes documentation typos and refines error handling when setting parent spans in Axum and Tonic middleware. By matching on SetParentError, the code now avoids logging warnings when a span is disabled. However, a bug was identified in trace_extractor.rs where a redundant warning log was retained outside the new match block, which results in duplicate logs and incorrect behavior for disabled spans.
flokli
force-pushed
the
no-warning-on-span-disabled
branch
from
ba67354 to
37a9133
Compare
This has been logging lots of unactionable warnings, don't log in that case. See davidB#310 (comment)
flokli
force-pushed
the
no-warning-on-span-disabled
branch
from
37a9133 to
2185c6c
Compare
Author
|
I think this probably works as intended, but could maybe be documented better (or the default features changed). See #310 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been logging lots of unactionable warnings, don't log in that
case.
See #310 (comment)
Also fixes a typo.