build: set version 0.38#341
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request synchronizes the versioning across the workspace by updating all crates and internal dependencies to version 0.38.0. The feedback suggests adopting workspace inheritance for the version field in the individual Cargo.toml files to improve maintainability and ensure consistency across the project.
| rust-version.workspace = true | ||
| edition.workspace = true | ||
| version = "0.33.1" | ||
| version = "0.38.0" |
There was a problem hiding this comment.
Since you are synchronizing versions across the workspace and have defined the version in the workspace root, you should use workspace inheritance here to simplify future updates and ensure consistency.
| version = "0.38.0" | |
| version.workspace = true |
| categories = ["development-tools::testing"] | ||
| edition.workspace = true | ||
| version = "0.34.1" | ||
| version = "0.38.0" |
There was a problem hiding this comment.
Since you are synchronizing versions across the workspace and have defined the version in the workspace root, you should use workspace inheritance here to simplify future updates and ensure consistency.
| version = "0.38.0" | |
| version.workspace = true |
| homepage = "https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk/tree/main/init-tracing-opentelemetry" | ||
| edition.workspace = true | ||
| version = "0.37.0" | ||
| version = "0.38.0" |
There was a problem hiding this comment.
Since you are synchronizing versions across the workspace and have defined the version in the workspace root, you should use workspace inheritance here to simplify future updates and ensure consistency.
| version = "0.38.0" | |
| version.workspace = true |
| homepage = "https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk/tree/main/tonic-tracing-opentelemetry" | ||
| edition.workspace = true | ||
| version = "0.32.2" | ||
| version = "0.38.0" |
There was a problem hiding this comment.
Since you are synchronizing versions across the workspace and have defined the version in the workspace root, you should use workspace inheritance here to simplify future updates and ensure consistency.
| version = "0.38.0" | |
| version.workspace = true |
| homepage = "https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk/tree/main/tracing-opentelemetry-instrumentation-sdk" | ||
| edition.workspace = true | ||
| version = "0.32.5" | ||
| version = "0.38.0" |
There was a problem hiding this comment.
Since you are synchronizing versions across the workspace and have defined the version in the workspace root, you should use workspace inheritance here to simplify future updates and ensure consistency.
| version = "0.38.0" | |
| version.workspace = true |
1 participant
No description provided.